feat: add slider upper and lower limits #410
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zheoreh
reviewed
Nov 28, 2023
| value: 0, | ||
| vertical: false, | ||
| startFromZero: false, | ||
| lowerLimit: undefined, |
There was a problem hiding this comment.
there is no sense to specify default values
|
could this be merge in as it is very helpful feature |
|
Any updates on this PR? It's a very helpful feature |
|
If you’re looking for upper and lower limit support, you can try this fork until the feature gets merged into the main branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prop name and description copied from https://github.com/callstack/react-native-slider