Test reviewpad #33
Open
Test reviewpad #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The host/guest in-game components that can be added to the GameComponent have test-dependencies. Hence we still need a TestGamecomponent.
- Refactor navigation to circumvent unsupported navigation arguments of Parcelables. - Improve structure of navigation command handling. - Improve QR code scanning error feedback.
# Conflicts: # .github/workflows/instrumented-tests.yml
Update recommended when updating to Android Studio ArcticFox 2020.3.1 Patch 3
- notifies user when not connected to a WLAN since it is required to host/join a game
- notifies user when not connected to a WLAN since it is required to host/join a game
…fig. change --> the NavHostController has the lifecycle of the outermost Composable. A config change has the consequence that the outermost Composable is destroyed and recreated, same for NavHostController.
…new game" buttons on HomeScreen.kt
by removing its reference when Dwitch() composable is destroyed
…tations all over the place
# Conflicts: # DwitchEngine/src/main/kotlin/ch/qscqlmpa/dwitchengine/actions/playcard/PlayCard.kt # app/src/main/java/ch/qscqlmpa/dwitch/ui/ingame/gameroom/DashboardScreen.kt
Lots of unfinished things here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.