show the right way of adding a badge to a UISegmentedControl #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pull request ... I've marked the right way and the wrong way of using a badge with a UISegmentedControl with your badge library. You don't have to put it into place that way, you can choose not to commit the few lines marked "wrong way" ... I only left it in place because my first reaction to a sample which seems to have extra lines (like the container view in "right way") is to optimize and remove them without realizing that there was a good reason to have them there. Guess I'm just protecting people like myself from making mistakes :)
I've also used a smaller font in badges just for the sake of smushing stuff together for demo.
I noticed that you made a change in your source recently from
UIExtendedEdgeNonetoUIRectEdgeNone... can you tell me what that was about?