fix: derive workspace from devcontainer config when using -c flag#185
Draft
lohrm-stabl wants to merge 1 commit intomainfrom
Draft
fix: derive workspace from devcontainer config when using -c flag#185lohrm-stabl wants to merge 1 commit intomainfrom
lohrm-stabl wants to merge 1 commit intomainfrom
Conversation
When specifying a custom devcontainer path with the -c flag, the workspace path is now automatically derived from the devcontainer config location instead of requiring the path to exist on the host filesystem. This fix addresses the issue where users couldn't open projects with custom devcontainer configurations because the workspace path validation was checking for container paths on the host filesystem. Changes: - Modified main.rs to derive workspace root from devcontainer config when -c flag is provided - Added support for container path parsing (e.g., /workspace/vscli/tests) to extract subfolder information - Updated launch.rs to accept subfolder parameter - Modified workspace.rs open() method to append subfolder to container workspace path The fix now properly handles: - Devcontainer configs in .devcontainer/ folders - Container paths like /workspace/<name>/<subfolder> - Relative subfolder paths - Absolute host paths relative to workspace root Fixes #82
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When specifying a custom devcontainer path with the -c flag, the workspace path is now automatically derived from the devcontainer config location instead of requiring the path to exist on the host filesystem.
This fix addresses the issue where users couldn't open projects with custom devcontainer configurations because the workspace path validation was checking for container paths on the host filesystem.
Changes:
The fix now properly handles:
Fixes #82