forked from microbit-foundation/cctd-ml-machine
-
Notifications
You must be signed in to change notification settings - Fork 4
Update onboarding with nudges and new welcome dialog #629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
microbit-grace
wants to merge
34
commits into
beta
Choose a base branch
from
onboarding-update
base: beta
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
3e75eca
Fix theme and upgrade ml-trainer-microbit theme package (#626)
microbit-grace 9f4f001
Update in user flow with nudges and new welcome dialog
microbit-matt-hillsdon 0bd326d
Change welcome dialog animation to step-by-step
microbit-grace 524a576
Quicker pre-connect video
microbit-grace b792c92
Update step-by-step to animate and to be above Youtube video
microbit-grace 3c2d4b0
Remove dimming when move microbit hint is visible
microbit-grace 5ee49bb
Update record button B hint text and image
microbit-grace 4af3434
Add hint for unnamed action with samples
microbit-grace 6134f21
Add background behind move-hint
microbit-grace a697421
Extend nudges for second action
microbit-grace 490b4c5
Add nudge for train
microbit-grace 040f04f
Remove second name action animation
microbit-grace 5dc0f70
Update train model nudge to use AI emoji
microbit-grace 8222746
Tweak record first action hint positioning
microbit-grace d340083
Update homepage step by step flow to static
microbit-grace c51445a
Add background behind train hint
microbit-grace 7363e65
Update nudges to be triggered by store actions instead of state
microbit-grace 3ed174a
Adjust move and train hint to not obscure / trigger scrollbars
microbit-grace abec2fa
Trigger welcome dialog when not connected and not trained
microbit-grace 5e32f7d
Prepare strings for translation
microbit-grace 19aba04
Update record hint copy
microbit-grace fe6b36e
Aria-hidden for emoji and arrow
microbit-grace 41aae0e
Update copy
microbit-grace 448bdd2
Screen reader support for nudges
microbit-grace bacfd06
Update E2E tests to handle welcome dialog
microbit-grace f157d11
Don't animate nudges if users prefer reduced motion
microbit-grace 4e2c19d
Remove unused strings
microbit-grace 06ab057
Remove hacky way to create initial action
microbit-grace 3e9ec0d
Tweaks
microbit-grace 6d6fef4
Revert skipping of playwright tests
microbit-grace 4c96886
Remove unused asset
microbit-grace b031eb8
Set hint to null on setActionName only when hint will be updated.
microbit-grace 3a1f7c4
Prettier
microbit-grace 35027ac
Tweak comment
microbit-grace File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Diff includes changes from #626 since this branch is based on the latest main. We will need to get changes #626 into
betabranch first