Avoid mixing up app/non-app historical state handles #7406
Merged
+194
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxtropets
changed the title
maxtropets
force-pushed
the
f/historical-handles-mixup
branch
from
d6ad7bd to
efc6b1c
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR addresses issue #6558 by preventing confusion between application and system historical state handles. The changes introduce a CompoundHandle type that pairs a RequestNamespace (System/App) with a RequestHandle, ensuring that system-level historical queries don't interfere with application-level queries when sequence numbers overlap.
Key changes:
- Modified internal historical query functions to use system-specific handles via
make_system_handle() - Added a new endpoint demonstrating custom handle usage for historical queries
- Added test coverage for the handle separation behavior
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/node/historical_queries_utils.cpp | Updated to use system-specific handles when fetching previous service identities and endorsements |
| src/node/historical_queries.h | Removed extraneous blank line |
| src/node/historical_queries_adapter.cpp | Removed outdated comment about buffer size calculation |
| samples/apps/logging/logging.cpp | Added new endpoint and handler demonstrating custom handle usage for historical queries |
| tests/recovery.py | Added test case verifying that overlapping seqnos work correctly with handle separation |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
eddyashton
reviewed
Oct 28, 2025
achamayou
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A somewhat ugly attempt to solve #6558. See if CI's happy.
UPD. CI is happy, I don't think there's both better and cheap way (in terms of interface changes) to fix this.