Wait for all nodes to finish self-healing-open before completing #7556
+7
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxtropets
approved these changes
Jan 7, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a premature exit bug in the start_in_self_healing_open method where the function would return immediately after the first node successfully opened, potentially causing subsequent recovery share submissions to fail if they targeted nodes that hadn't finished their self-healing process.
Key Changes:
- Replaced early
returnstatement withwaiting_nodes.remove(node)to ensure all nodes complete their self-healing process before the function exits
eddyashton
approved these changes
Jan 7, 2026
Contributor
Author
|
Pipelined behind #7561 as this PR's CI is failing frequently due to it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the first node queried was still live and had opened, then the script would immediately exit making the next request to the submit_recovery_shares fail, if it chose a failed node.
This way the only exit is either the all complete path, or the timeout path.