Update code review instructions for shell scripts #7559
Merged
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added guideline for handling pipe operators in shell scripts.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a new code review guideline for shell scripts that requires the use of the pipefail option when pipe operators are present. This ensures that failures in any command within a pipeline are properly detected and not masked by subsequent commands.
Key Changes:
- Added a guideline requiring
set -o pipefailin shell scripts that use pipe operators
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Member
Author
|
@copilot open a new pull request to apply changes based on the comments in this thread |
Contributor
|
@achamayou I've opened a new pull request, #7560, to work on those changes. Once the pull request is ready, I'll request review from you. |
cjen1-msft
approved these changes
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added guideline for handling pipe operators in shell scripts.