Refactor IID properties for non-projected ___Impl types in WinRT.Runtime
#2092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces direct references to interface implementation IIDs with constants from WellKnownWindowsInterfaceIIDs across multiple ABI and interop files. This change improves consistency and maintainability by centralizing interface ID definitions.
Replaces direct references to interface IID getters (e.g., IUnknownImplget_IID) with WellKnownInterfaceIIDs static properties throughout the InteropTypeDefinitionBuilder classes. Updates InteropReferences to provide WellKnownInterfaceIIDs member references and removes obsolete per-implementation IID getters. This centralizes and simplifies access to well-known interface IIDs.
Replaced direct IID assignments from implementation classes with references to WindowsRuntime.InteropServices.WellKnownInterfaceIIDs constants for standard interfaces. This improves clarity and ensures consistency in IID usage.
Prefixed references to WindowsRuntime.InteropServices.WellKnownInterfaceIIDs and related implementation classes with 'global::' to ensure correct namespace resolution and avoid potential conflicts. This change improves code clarity and compatibility, especially in projects with custom or nested namespaces.
manodasanW
approved these changes
Nov 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #2083.
This PR applies the same refactoring to all
___Implnon-projected types in WinRT.Runtime, for consistency.With this change, all IIDs are always either in
WellKnownInterfaceIIDs, or in a generatedInterfaceIIDstype.