- 
                Notifications
    
You must be signed in to change notification settings  - Fork 89
 
Platform toolset143 compatibility #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Platform toolset143 compatibility #57
Conversation
| 
           @dimensional-difficulties please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information. 
 Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”), 
 
 
  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Submitted some requested changes & comments
| 
               | 
          ||
| if (GI == 0) | ||
| TileClass[Gid.xy] = float3(TileMaxCoC, TileMinDepth, TileMaxDepth); | ||
| TileClass[Gid.xy] = float3(gs_MaximumCoC[0], gs_FarthestDepthSearch[0], gs_FarthestDepthSearch[0]); | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be gs_ClosestDepthSearch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(specifically, the first gs_FarthestDepthSearch on this line)
| float3 main( float4 position : SV_Position, float2 uv : TexCoord0 ) : SV_Target0 | ||
| { | ||
| float3 MainColor = ApplyREC2084Curve(ScaleBuffer(uv) / 10000.0); | ||
| float3 MainColor = ApplyREC2084Curve( saturate(ScaleBuffer(uv) / 10000.0) ); | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not very familiar with this method - what caused the need to add saturate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also small nit: spacing
| TileMaxDepth = max(TileMaxDepth, gs_FarthestDepthSearch[(GI + i) % 64]); | ||
| TileMaxCoC = max(TileMaxCoC, gs_MaximumCoC[(GI + i) % 64]); | ||
| if (GI < i) | ||
| { | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm... it would be helpful to have a description in the PR for the reasoning of change in this method. Should this be setting [GI] instead of [i]?
Fixing compatibility issue with Visual C++ version 143. Updating shaders to match those in https://github.com/microsoft/DirectX-Graphics-Samples/tree/master/MiniEngine/Core/Shaders, and updating project files as required.