Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion azure/packages/azure-service-utils/src/generateToken.ts
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ export function generateToken(

return jsrsasign.jws.JWS.sign(
// External API uses null
// eslint-disable-next-line unicorn/no-null
// eslint-disable-next-line @typescript-eslint/no-restricted-types
null,
JSON.stringify({ alg: "HS256", typ: "JWT" }),
claims,
Expand Down
2 changes: 1 addition & 1 deletion build-tools/packages/version-tools/src/schemes.ts
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ export function bumpVersionScheme(
case "major":
case "minor":
case "patch": {
// eslint-disable-next-line unicorn/no-null
// eslint-disable-next-line @typescript-eslint/no-restricted-types
return sv?.inc(bumpType) ?? null;
}
default: {
Expand Down
11 changes: 11 additions & 0 deletions common/build/eslint-config-fluid/base.js
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,17 @@ module.exports = {
"@typescript-eslint/no-misused-new": "error",
"@typescript-eslint/no-non-null-assertion": "error",
"@typescript-eslint/no-require-imports": "error",
"@typescript-eslint/no-restricted-types": [
"error",
{
types: {
null: {
message: "Use 'undefined' instead of 'null'",
fixWith: "undefined",
},
},
},
],
"@typescript-eslint/no-shadow": [
"error",
{
Expand Down
14 changes: 0 additions & 14 deletions common/build/eslint-config-fluid/minimal-deprecated.js
Original file line number Diff line number Diff line change
Expand Up @@ -84,10 +84,6 @@ module.exports = {
project: "./tsconfig.json",
},
plugins: [
// Plugin documentation: https://www.npmjs.com/package/@rushstack/eslint-plugin
"@rushstack/eslint-plugin",
// Plugin documentation: https://www.npmjs.com/package/@rushstack/eslint-plugin-security
"@rushstack/eslint-plugin-security",
// Plugin documentation: https://www.npmjs.com/package/@typescript-eslint/eslint-plugin
"@typescript-eslint/eslint-plugin",
// Plugin documentation: https://www.npmjs.com/package/eslint-plugin-jsdoc
Expand Down Expand Up @@ -127,12 +123,6 @@ module.exports = {
*/
"@fluid-internal/fluid/no-unchecked-record-access": "error",

/**
* The @rushstack rules are documented in the package README:
* {@link https://www.npmjs.com/package/@rushstack/eslint-plugin}
*/
"@rushstack/no-new-null": "warn",

/**
* RATIONALE: Harmless.
*
Expand Down Expand Up @@ -225,10 +215,6 @@ module.exports = {

// #region DISABLED INTENTIONALLY

/**
* Disabled because we don't require that all variable declarations be explicitly typed.
*/
"@rushstack/typedef-var": "off",
"@typescript-eslint/explicit-function-return-type": "off",
"@typescript-eslint/explicit-member-accessibility": "off",

Expand Down
3 changes: 0 additions & 3 deletions common/build/eslint-config-fluid/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,6 @@
"dependencies": {
"@eslint-community/eslint-plugin-eslint-comments": "~4.5.0",
"@fluid-internal/eslint-plugin-fluid": "^0.4.0",
"@rushstack/eslint-patch": "~1.12.0",
"@rushstack/eslint-plugin": "~0.19.0",
"@rushstack/eslint-plugin-security": "~0.11.0",
"@typescript-eslint/eslint-plugin": "~8.18.2",
"@typescript-eslint/parser": "~8.18.2",
"eslint-config-biome": "~2.1.3",
Expand Down

This file was deleted.

109 changes: 0 additions & 109 deletions common/build/eslint-config-fluid/pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

21 changes: 12 additions & 9 deletions common/build/eslint-config-fluid/printed-configs/default.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,6 @@
"promise",
"jsdoc",
"@typescript-eslint",
"@rushstack/security",
"@rushstack",
"unicorn",
"tsdoc"
],
Expand Down Expand Up @@ -75,12 +73,6 @@
"@fluid-internal/fluid/no-unchecked-record-access": [
"error"
],
"@rushstack/no-new-null": [
"error"
],
"@rushstack/typedef-var": [
"off"
],
"@stylistic/array-bracket-newline": [
"off"
],
Expand Down Expand Up @@ -849,6 +841,17 @@
]
}
],
"@typescript-eslint/no-restricted-types": [
"error",
{
"types": {
"null": {
"message": "Use 'undefined' instead of 'null'",
"fixWith": "undefined"
}
}
}
],
"@typescript-eslint/no-shadow": [
"error",
{
Expand Down Expand Up @@ -1943,7 +1946,7 @@
"error"
],
"unicorn/no-null": [
"error"
"off"
],
"unicorn/no-object-as-default-parameter": [
"error"
Expand Down
21 changes: 12 additions & 9 deletions common/build/eslint-config-fluid/printed-configs/minimal.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,7 @@
"tsdoc",
"promise",
"jsdoc",
"@typescript-eslint",
"@rushstack/security",
"@rushstack"
"@typescript-eslint"
],
"reportUnusedDisableDirectives": true,
"rules": {
Expand Down Expand Up @@ -75,12 +73,6 @@
"@fluid-internal/fluid/no-unchecked-record-access": [
"error"
],
"@rushstack/no-new-null": [
"warn"
],
"@rushstack/typedef-var": [
"off"
],
"@stylistic/array-bracket-newline": [
"off"
],
Expand Down Expand Up @@ -830,6 +822,17 @@
]
}
],
"@typescript-eslint/no-restricted-types": [
"error",
{
"types": {
"null": {
"message": "Use 'undefined' instead of 'null'",
"fixWith": "undefined"
}
}
}
],
"@typescript-eslint/no-shadow": [
"error",
{
Expand Down
Loading
Loading