Skip to content

BUG/ [Routerlicious-Driver]Add undefined value handling in restWrapper #25737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
neerajcharokar wants to merge 1 commit into from
Closed

BUG/ [Routerlicious-Driver]Add undefined value handling in restWrapper #25737

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/drivers/routerlicious-driver/src/restWrapper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,10 @@ const buildRequestUrl = (requestConfig: AxiosRequestConfig) =>
const axiosBuildRequestInitConfig = (requestConfig: AxiosRequestConfig): RequestInit => {
const requestInit: RequestInit = {
method: requestConfig.method,
// NOTE: I believe that although the Axios type permits non-string values in the header, here we are
// guaranteed the requestConfig only has string values in its header.
headers: requestConfig.headers as Record<string, string>,
body: requestConfig.data,
// Only set headers if they exist to avoid passing undefined
...(requestConfig.headers && { headers: requestConfig.headers as Record<string, string> }),
// Only set body if it exists to avoid passing undefined
...(requestConfig.data !== undefined && { body: requestConfig.data }),
};
return requestInit;
};
Expand Down