-
Notifications
You must be signed in to change notification settings - Fork 559
Shared Tree: Simple Schema codec #25741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ests yet and I might be missing members.
TommyBrosman
commented
Oct 23, 2025
packages/dds/tree/src/simple-tree/api/viewSchemaToViewCompatibilitySchema.ts
Outdated
Show resolved
Hide resolved
…ewCompatibility mode.
…reful serialization of each type, though I think this safer and more durable than a more generic approach.
…owedTypesIdentifiers with allowedTypesInfo.
packages/dds/tree/src/simple-tree/node-kinds/array/arrayNode.ts
Outdated
Show resolved
Hide resolved
- Regenerated API files.
- Regenerated API Extractor output.
…h is beta). - PR feedback.
TommyBrosman
commented
Nov 5, 2025
packages/dds/tree/src/simple-tree/api/simpleSchemaSerializer.ts
Outdated
Show resolved
Hide resolved
Josmithr
reviewed
Nov 5, 2025
Josmithr
reviewed
Nov 6, 2025
packages/dds/tree/src/simple-tree/api/simpleSchemaSerializer.ts
Outdated
Show resolved
Hide resolved
Josmithr
reviewed
Nov 6, 2025
packages/dds/tree/src/simple-tree/api/simpleSchemaSerializer.ts
Outdated
Show resolved
Hide resolved
Josmithr
reviewed
Nov 6, 2025
packages/dds/tree/src/simple-tree/api/simpleSchemaSerializer.ts
Outdated
Show resolved
Hide resolved
Josmithr
reviewed
Nov 6, 2025
packages/dds/tree/src/simple-tree/api/simpleSchemaSerializer.ts
Outdated
Show resolved
Hide resolved
packages/dds/tree/src/simple-tree/api/simpleSchemaSerializer.ts
Outdated
Show resolved
Hide resolved
Josmithr
approved these changes
Nov 6, 2025
Contributor
Josmithr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple more suggestions, but overall looks good to me :)
packages/dds/tree/src/simple-tree/api/simpleSchemaSerializer.ts
Outdated
Show resolved
Hide resolved
Josmithr
approved these changes
Nov 7, 2025
Contributor
|
🔗 Found some broken links! 💔 Run a link check locally to find them. See linkcheck output |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: dds: tree
area: dds
Issues related to distributed data structures
area: framework
Framework is a tag for issues involving the developer framework. Eg Aqueduct
base: main
PRs targeted against main branch
public api change
Changes to a public API
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces new APIs for encoding and decoding view schemas. Also adds new fields to Simple Schemas to support compatibility checking scenarios.
Description
New APIs (in alpha):
encodeSimpleSchema(simpleSchema: SimpleTreeSchema): JsonCompatibleReadOnly- Encodes a Simple Schema into a JSON-compatible object format.decodeSimpleSchema(encodedSchema: JsonCompatibleReadOnly, validator?: FormatValidator): SimpleTreeSchema- Decodes a Simple Schema from a JSON-compatible object format.Other changes:
toSimpleTreeSchemato include `compatibility-related fields. These include:isStagedallowUnknownOptionalTypesReviewer Guidance
Todo