[Light Switch] Dedupe sun time updates on start up #42818
+7
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR eliminates redundant sun time calculations during PowerToys startup by preventing duplicate work when both the "new day" check and "settings changed" check would trigger simultaneously on first launch.
Key Changes:
- Initializes previous settings state before the initial theme application
- Guards the coordinates change detection to skip on first run (when
g_lastUpdatedDay == -1)
| settings.scheduleMode == ScheduleMode::SunsetToSunrise); | ||
| bool coordsChanged = (prevLat != settings.latitude || prevLon != settings.longitude); | ||
|
|
||
| // ensures that coordsChanged is false on first run (since we already did this work below) |
There was a problem hiding this comment.
The comment references 'this work below', but the initial sun time calculation happens above at lines 224-241. The comment should say 'above' instead of 'below' to accurately reflect the code location.
Suggested change
| // ensures that coordsChanged is false on first run (since we already did this work below) | |
| // ensures that coordsChanged is false on first run (since we already did this work above) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Issue: Currently we are doing the same work twice on first start up of Powertoys.
If this is a fresh start, the service will have no values to compare to so it will hit point 1 because it will always appear to be a new day if the service just started and also point 2 since there is no "prev" values to compare to.
Fix: added a guard to skip point 2 on a fresh start (ie:
g_lastUpdatedDay == -1) which allows the start-up logic to handle this update while still allowing for an update in settings to trigger a sun times update later in the life cycle if needed.