Open
Conversation
behnam-o
approved these changes
Apr 8, 2026
|
|
||
| # Already an existing file on disk — keep as-is | ||
| if Path(piece.original_value).is_file(): | ||
| # Already an existing file on disk — keep as-is. |
Contributor
There was a problem hiding this comment.
nit: I think the length check is unnecessary, and also I suggest you don't need to the extra variable is_existing_file, which is set in the try/catch block and used [only] right after it. instead, this might be more readable:
(basically just add a try: <current-code> except (OSError): <pass>
try:
if Path(piece.original_value).is_file():
if piece.converted_value is None:
piece.converted_value = piece.original_value
continue
except (OSError, ValueError):
passThis will take care of cases where the content is indeed resolvable to a file, and pass over it when it's not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Sending audio files ie via Realtime is failing with the GUI because the whole base64 is being read by
Path(piece.original_value).is_file(), which treats the whole string as a potential filename, which obviously is too long and thus errors out.As a fix, this adds two guards:
This lets the base64 audio data flow through to the serializer where it gets properly decoded and saved as a .wav file.
Tests and Documentation
Tested manually via UI and reran all tests and added new unit test