Skip to content

Remove the paramter not used to reduce confustion #627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove the paramter not used to reduce confustion #627

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions Kubernetes/windows/debug/VFP.psm1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ function Get-VfpPorts()
{
Param(
[ValidateNotNullorEmpty()]
[string]$SwitchName = $(throw "Please provide a switch name."),
[parameter(Mandatory=$false)][string]$MacAddress
)
$vfpPorts = @()
Expand Down Expand Up @@ -323,7 +322,7 @@ function Get-VfpRules_HnsEndpointId()
)

$ep = (Get-HnsEndpoint $EndpointId)
$port = Get-VfpPorts -SwitchName $ep.VirtualNetworkName -MacAddress $ep.MacAddress
$port = Get-VfpPorts -MacAddress $ep.MacAddress

throw "TBD"

Expand Down
3 changes: 1 addition & 2 deletions Kubernetes/windows/debug/dumpVfpPolicies.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
param(
[string]$switchName = $(throw "please specify a switch name"),
[string]$outfile = "vfprules.txt"
)

Expand All @@ -22,7 +21,7 @@ ipmo $helper
DownloadFile -Url "https://raw.githubusercontent.com/$GithubSDNRepository/master/Kubernetes/windows/debug/VFP.psm1" -Destination $BaseDir\VFP.psm1
ipmo $BaseDir\VFP.psm1

$ports = Get-VfpPorts -SwitchName $switchName
$ports = Get-VfpPorts

# Dump the port info
$ports | select 'Port name', 'Mac Address', 'PortId' | Out-File $outfile -Encoding ascii -Append
Expand Down