Add DCAT registration remediation#14450
Draft
florelis wants to merge 2 commits intomicrosoft:feature/wsl-for-appsfrom
Draft
Add DCAT registration remediation#14450florelis wants to merge 2 commits intomicrosoft:feature/wsl-for-appsfrom
florelis wants to merge 2 commits intomicrosoft:feature/wsl-for-appsfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a remediation to re-register WSL components with DCAT on every service launch, addressing cases where the DCAT registration registry key is missing or incorrect.
Changes:
- Call
wsl::windows::common::helpers::RegisterWithDcat()during startup of bothwslserviceandwslaservice. - Add
RegisterWithDcat()implementation tosrc/windows/common/helpers.*to write the DCAT registry value. - Introduce a
DCAT_REGISTRATION_KEYcompile definition from CMake for the registry path.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/windows/wslaservice/exe/ServiceMain.cpp | Calls DCAT registration during WSLA service startup. |
| src/windows/service/exe/ServiceMain.cpp | Calls DCAT registration during WSL service startup; adds include. |
| src/windows/common/helpers.hpp | Declares RegisterWithDcat() helper API. |
| src/windows/common/helpers.cpp | Implements DCAT registry write logic. |
| CMakeLists.txt | Adds compile definition for DCAT_REGISTRATION_KEY. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
To remediate the case where the registration key gets deleted, we re-set the key on every launch.
PR Checklist
Detailed Description of the Pull Request / Additional comments
I added the remediation to both
wslserviceandwslaservice, near the end of theOnServiceStarting(). The registration function writes to the registry without checking, as we would want to update the version if it is wrong for some reason.I added an option to set the registration version to 0.0.0.0, which can be used for the initial installation.
Pending:
Validation Steps Performed