Skip to content

Split WSLA/WSLC tests into a separate CI runner#14472

Merged
benhillis merged 2 commits intofeature/wsl-for-appsfrom
user/benhill/wslc_test_pass
Mar 20, 2026
Merged

Split WSLA/WSLC tests into a separate CI runner#14472
benhillis merged 2 commits intofeature/wsl-for-appsfrom
user/benhill/wslc_test_pass

Conversation

@benhillis
Copy link
Member

Add a WSLA_TEST_CLASS macro that tags test classes with TestCategory=WSLA, allowing TAEF /select filters to split them into a dedicated CI job.

  • Add WSLA_TEST_CLASS macro that adds TestCategory=WSLA metadata
  • Tag all 12 WSLA/WSLC test classes (WSLATests, WslcSdkTests, WSLC E2E, WSLC CLI)
  • Add 'wsla' version to CI pipeline test matrix

This runs WSLA/WSLC container tests (153 tests) in parallel with traditional WSL tests (389 tests), reducing the critical path of the CI pipeline.

@benhillis benhillis requested a review from a team as a code owner March 19, 2026 00:04
Copilot AI review requested due to automatic review settings March 19, 2026 00:04
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR splits WSLA/WSLC (container-related) Windows tests into a dedicated CI lane by tagging those test classes with a TestCategory=WSLA TAEF property and updating CloudTest/pipeline configuration to filter on that category.

Changes:

  • Introduce WSLA_TEST_CLASS (and refactor shared class properties) to apply TestCategory=WSLA metadata to selected TAEF test classes.
  • Update CloudTest jobs to (a) exclude WSLA-tagged tests from the standard WSL test run and (b) add a new WSLA-only test job group.
  • Extend the pipeline test matrix with a wsla entry to run the new CloudTest map.

Reviewed changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated no comments.

Show a summary per file
File Description
test/windows/wslc/e2e/WSLCE2EImageInspectTests.cpp Switch test class to WSLA_TEST_CLASS so it’s selected by the WSLA CI lane.
test/windows/wslc/e2e/WSLCE2EImageDeleteTests.cpp Switch test class to WSLA_TEST_CLASS for WSLA CI selection.
test/windows/wslc/e2e/WSLCE2EImageBuildTests.cpp Switch test class to WSLA_TEST_CLASS for WSLA CI selection.
test/windows/wslc/e2e/WSLCE2EGlobalTests.cpp Switch test class to WSLA_TEST_CLASS for WSLA CI selection.
test/windows/wslc/e2e/WSLCE2EContainerTests.cpp Switch test class to WSLA_TEST_CLASS for WSLA CI selection.
test/windows/wslc/e2e/WSLCE2EContainerCreateTests.cpp Switch test class to WSLA_TEST_CLASS for WSLA CI selection.
test/windows/wslc/WSLCCLIParserUnitTests.cpp Switch test class to WSLA_TEST_CLASS for WSLA CI selection.
test/windows/wslc/WSLCCLIExecutionUnitTests.cpp Switch test class to WSLA_TEST_CLASS for WSLA CI selection.
test/windows/wslc/WSLCCLICommandUnitTests.cpp Switch test class to WSLA_TEST_CLASS for WSLA CI selection.
test/windows/wslc/WSLCCLIArgumentUnitTests.cpp Switch test class to WSLA_TEST_CLASS for WSLA CI selection.
test/windows/WslcSdkTests.cpp Switch test class to WSLA_TEST_CLASS for WSLA CI selection.
test/windows/WSLATests.cpp Switch test class to WSLA_TEST_CLASS for WSLA CI selection.
test/windows/Common.h Add WSL_TEST_CLASS_PROPERTIES and new WSLA_TEST_CLASS macro (adds TestCategory=WSLA).
cloudtest/TestGroup.xml.in Exclude WSLA-tagged tests from the default test job via a TAEF /select filter.
cloudtest/TestGroup-wsla.xml.in Add a WSLA-only CloudTest job that runs only TestCategory=WSLA tests.
cloudtest/CMakeLists.txt Generate an additional CloudTest map/group output directory for the WSLA lane.
.pipelines/test-stage.yml Add wsla to the pipeline test matrix to schedule the new WSLA lane.

You can also share your feedback on Copilot code review. Take the survey.

@benhillis benhillis force-pushed the user/benhill/wslc_test_pass branch from 536a617 to 4ec05fc Compare March 19, 2026 14:41
Copilot AI review requested due to automatic review settings March 19, 2026 17:03
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a WSLA-specific test category and CI split so WSLA/WSLC tests can run in a dedicated CloudTest/TAEF job, reducing overall CI critical-path duration.

Changes:

  • Introduces WSLA_TEST_CLASS (via common test macros) to tag WSLA/WSLC-related test classes with TestCategory=WSLA.
  • Splits CloudTest execution into two groups using TAEF /select filters (non-WSLA vs WSLA) and adds a new WSLA CloudTest group template.
  • Extends the pipeline test matrix with a wsla entry and generates per-image WSLA CloudTest specs.

Reviewed changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
tools/test/CloudTest-Setup.bat Configures WER LocalDumps and creates a crash dump directory during CloudTest setup.
test/windows/wslc/e2e/WSLCE2EImageInspectTests.cpp Switches test class metadata macro to WSLA_TEST_CLASS.
test/windows/wslc/e2e/WSLCE2EImageDeleteTests.cpp Switches test class metadata macro to WSLA_TEST_CLASS.
test/windows/wslc/e2e/WSLCE2EImageBuildTests.cpp Switches test class metadata macro to WSLA_TEST_CLASS.
test/windows/wslc/e2e/WSLCE2EGlobalTests.cpp Switches test class metadata macro to WSLA_TEST_CLASS.
test/windows/wslc/e2e/WSLCE2EContainerTests.cpp Switches test class metadata macro to WSLA_TEST_CLASS.
test/windows/wslc/e2e/WSLCE2EContainerCreateTests.cpp Switches test class metadata macro to WSLA_TEST_CLASS.
test/windows/wslc/WSLCCLIParserUnitTests.cpp Switches test class metadata macro to WSLA_TEST_CLASS.
test/windows/wslc/WSLCCLIExecutionUnitTests.cpp Switches test class metadata macro to WSLA_TEST_CLASS.
test/windows/wslc/WSLCCLICommandUnitTests.cpp Switches test class metadata macro to WSLA_TEST_CLASS.
test/windows/wslc/WSLCCLIArgumentUnitTests.cpp Switches test class metadata macro to WSLA_TEST_CLASS.
test/windows/WslcSdkTests.cpp Switches test class metadata macro to WSLA_TEST_CLASS.
test/windows/WSLATests.cpp Switches test class metadata macro to WSLA_TEST_CLASS.
test/windows/Common.h Refactors common class properties into WSL_TEST_CLASS_PROPERTIES and adds WSLA_TEST_CLASS with TestCategory=WSLA.
cloudtest/TestGroup.xml.in Excludes WSLA tests from the main TAEF job via /select.
cloudtest/TestGroup-wsla.xml.in Adds a new CloudTest group that runs only WSLA-tagged tests via /select.
cloudtest/CMakeLists.txt Adds generation of per-image WSLA CloudTest specs.
.pipelines/test-stage.yml Adds wsla to the test matrix versions.

You can also share your feedback on Copilot code review. Take the survey.

Copilot AI review requested due to automatic review settings March 19, 2026 22:27
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enables splitting WSLA/WSLC container-related tests into a dedicated CloudTest job by tagging those test classes with TestCategory=WSLA and updating CloudTest/CI to run @TestCategory='WSLA' separately from the rest of the suite.

Changes:

  • Introduces WSLA_TEST_CLASS (adds TestCategory=WSLA) and applies it across WSLA/WSLC test classes.
  • Updates CloudTest TestGroup definitions to exclude WSLA tests from the default job and adds a new WSLA-only TestGroup.
  • Extends the pipeline test matrix to include a wsla version/job.

Reviewed changes

Copilot reviewed 19 out of 19 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tools/test/CloudTest-Setup.bat Configures WER LocalDumps to capture full crash dumps during CloudTest runs.
test/windows/wslc/e2e/WSLCE2EImageInspectTests.cpp Tags test class as WSLA via WSLA_TEST_CLASS.
test/windows/wslc/e2e/WSLCE2EImageDeleteTests.cpp Tags test class as WSLA via WSLA_TEST_CLASS.
test/windows/wslc/e2e/WSLCE2EImageBuildTests.cpp Tags test class as WSLA via WSLA_TEST_CLASS.
test/windows/wslc/e2e/WSLCE2EGlobalTests.cpp Tags test class as WSLA via WSLA_TEST_CLASS.
test/windows/wslc/e2e/WSLCE2EContainerTests.cpp Tags test class as WSLA via WSLA_TEST_CLASS.
test/windows/wslc/e2e/WSLCE2EContainerCreateTests.cpp Tags test class as WSLA via WSLA_TEST_CLASS.
test/windows/wslc/WSLCCLIParserUnitTests.cpp Tags test class as WSLA via WSLA_TEST_CLASS.
test/windows/wslc/WSLCCLIExecutionUnitTests.cpp Tags test class as WSLA via WSLA_TEST_CLASS.
test/windows/wslc/WSLCCLICommandUnitTests.cpp Tags test class as WSLA via WSLA_TEST_CLASS.
test/windows/wslc/WSLCCLIArgumentUnitTests.cpp Tags test class as WSLA via WSLA_TEST_CLASS.
test/windows/WslcSdkTests.cpp Tags class as WSLA and adds extra SEH logging around a functional test block.
test/windows/WSLATests.cpp Tags class as WSLA via WSLA_TEST_CLASS.
test/windows/Common.h Adds WSL_TEST_CLASS_PROPERTIES and new WSLA_TEST_CLASS macro.
test/windows/Common.cpp Adjusts lambda capture to explicitly capture this.
cloudtest/TestGroup.xml.in Excludes WSLA tests from the default job via /select:"not(@TestCategory='WSLA')"
cloudtest/TestGroup-wsla.xml.in Adds a WSLA-only CloudTest group via /select:"@TestCategory='WSLA'".
cloudtest/CMakeLists.txt Generates an additional *-wsla CloudTest group per image.
.pipelines/test-stage.yml Adds wsla to the test matrix versions.

Copilot AI review requested due to automatic review settings March 20, 2026 01:55
@benhillis benhillis force-pushed the user/benhill/wslc_test_pass branch from d6fd406 to 1911814 Compare March 20, 2026 01:55
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated 1 comment.

@benhillis benhillis force-pushed the user/benhill/wslc_test_pass branch from 1911814 to 439f52c Compare March 20, 2026 16:51
@benhillis benhillis requested a review from Copilot March 20, 2026 16:51
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 18 out of 18 changed files in this pull request and generated 5 comments.

@benhillis benhillis requested a review from Copilot March 20, 2026 17:30
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 18 out of 18 changed files in this pull request and generated no new comments.

@benhillis benhillis merged commit e61174d into feature/wsl-for-apps Mar 20, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants