-
Couldn't load subscription status.
- Fork 704
Fix FlipView LocalizedControlType for accessibility compliance #1996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: niels9001 <9866362+niels9001@users.noreply.github.com>
Co-authored-by: niels9001 <9866362+niels9001@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Remove the tests
- Dont' at any a11y specific code into the code snippets, as these are not relevant for the code snippet
…dback Co-authored-by: niels9001 <9866362+niels9001@users.noreply.github.com>
Done! I've removed all tests and removed the LocalizedControlType from the XAML code snippets while keeping them on the actual FlipView controls for accessibility. The code examples are now clean and focused on core functionality. Changes in commit 9bb8b0f. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't seem to work
Could you provide more details about what specifically isn't working? I added I notice the test file AxeHelper.cs excludes the
What specific behavior or error are you seeing? Warning Firewall rules blocked me from connecting to one or more addressesI tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
This PR addresses an accessibility issue where FlipView controls in the WinUI 3 Gallery lacked proper
LocalizedControlTypeUI Automation properties, making it difficult for screen readers to identify the control type correctly.Problem
The issue was identified through accessibility testing with Fast Pass, which found that FlipView controls did not have meaningful
LocalizedControlTypeproperties set. This caused screen readers to announce generic control types instead of the specific "FlipView" control type, impacting the user experience for users relying on assistive technologies.Solution
Added
AutomationProperties.LocalizedControlType="FlipView"to all FlipView controls inFlipViewPage.xaml:The XAML code snippets remain clean and focused on core functionality, without accessibility-specific properties, to maintain their educational value.
Impact
NameExcludesLocalizedControlTypeThis change improves the accessibility experience for users with disabilities while maintaining full backward compatibility and keeping code examples educational.
Fixes #1956.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.