Replace MainWindow with plain Window in sample projects #2063
Conversation
| private void createNewWindow_Click(object sender, RoutedEventArgs e) | ||
| { | ||
| var newWindow = new MainWindow(); | ||
| var newWindow = new Window |
There was a problem hiding this comment.
Reading this was painful 😅, can't we just create a NewWindow or SecondaryWindow?
There was a problem hiding this comment.
My intension was to avoid adding custom code to the sample as much as possible, but sure I can do that.🙂
There was a problem hiding this comment.
I agree with the both of you, its difficult to read but for the sake of the sample we should not rely on helpers. Do we need to need to have ThemeHelper provide the theme?
Also can we call the constructor instead of omitting the "()"? 😄
There was a problem hiding this comment.
for the sake of the sample we should not rely on helpers
I completely agree.
Do we need to need to have ThemeHelper provide the theme?
If we want the new window use the app theme, which might differ from the system theme, we should set it here using ThemeHelper. We can remove it from the sample code (CreateWindowSample1.txt).
We can get the theme from the parent.
Also can we call the constructor instead of omitting the "()"? 😄
Yes, we can, but I'll add them back since I'm not sure is preferred or not. 🙂
| private void createNewWindow_Click(object sender, RoutedEventArgs e) | ||
| { | ||
| var newWindow = new MainWindow(); | ||
| var newWindow = new Window |
There was a problem hiding this comment.
I agree with the both of you, its difficult to read but for the sake of the sample we should not rely on helpers. Do we need to need to have ThemeHelper provide the theme?
Also can we call the constructor instead of omitting the "()"? 😄
|
/azp run |
3 participants
Description
This PR updates
WindowHelper.CreateWindow()to return a plainWindowinstead ofMainWindow, which was tightly coupled to several static members.Motivation and Context
Fixes #2062.
How Has This Been Tested?
Manually tested.
Screenshots (if appropriate):
Types of changes