Skip to content

Change Nuget version format #5945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Change Nuget version format #5945

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8774ba7
Bootstrap knows how to create verison 2 family name
Oct 20, 2025
d3cd969
Change to PatchVersion with Revision
Oct 24, 2025
96f1713
Change symbol before Date to '-'
Oct 27, 2025
d728067
Revert back to '+'
Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions build/AzurePipelinesTemplates/WindowsAppSDK-PackTransportPackage-Stage.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,8 +185,7 @@ stages:
}

$buildType = '$(channel)'
$majorMinorPatchRev = '$(MajorVersion).$(MinorVersion).$(versionMinDate)'
$majorMinorPatchRev = $majorMinorPatchRev + $paddedRevision
$majorMinorPatchRev = '$(MajorVersion).$(MinorVersion).$(PatchVersion)'

if ($env:ComponentType)
{
Expand Down Expand Up @@ -219,7 +218,11 @@ stages:
$formattedTag = ''
if(-not [String]::IsNullOrEmpty($versionTag))
{
$formattedTag = '-' + $versionTag
$formattedTag = '-' + $versionTag + "+" + $(versionMinDate) + $paddedRevision
}
else
{
$formattedTag = "+" + $(versionMinDate) + $paddedRevision
}
Write-Host "Using Release Versioning"
$version = $majorMinorPatchRev + $formattedTag
Expand Down
18 changes: 15 additions & 3 deletions dev/WindowsAppRuntime_BootstrapDLL/MddBootstrap.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -508,12 +508,24 @@ std::wstring GetFrameworkPackageFamilyName(
PCWSTR packageVersionTag{ !versionTag ? L"" : versionTag };
PCWSTR packageVersionTagDelimiter{ (packageVersionTag[0] == L'\0') ? L"" : L"-"};

const std::wstring packageFamilyName{ std::format(L"{}.{}.{}{}{}_8wekyb3d8bbwe",
if (majorVersion == 1)
{
const std::wstring packageFamilyName{ std::format(L"{}.{}.{}{}{}_8wekyb3d8bbwe",
namePrefix, majorVersion, minorVersion,
packageVersionTagDelimiter, packageVersionTag) };
THROW_HR_IF_MSG(E_INVALIDARG, packageFamilyName.length() > PACKAGE_FAMILY_NAME_MAX_LENGTH, "%ls", packageFamilyName.c_str());
THROW_HR_IF_MSG(E_INVALIDARG, packageFamilyName.length() > PACKAGE_FAMILY_NAME_MAX_LENGTH, "%ls", packageFamilyName.c_str());

return packageFamilyName;
return packageFamilyName;
}
else
{
const std::wstring packageFamilyName{ std::format(L"{}.{}{}{}_8wekyb3d8bbwe",
namePrefix, majorVersion,
packageVersionTagDelimiter, packageVersionTag) };
THROW_HR_IF_MSG(E_INVALIDARG, packageFamilyName.length() > PACKAGE_FAMILY_NAME_MAX_LENGTH, "%ls", packageFamilyName.c_str());

return packageFamilyName;
}
}

/// Determine the path for the Windows App Runtime Framework package
Expand Down