Skip to content

.NET: [Bug]: When converting from AGUIToolMessage to ChatMessage, the MessageId is lost. #4342 #4346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
IharYakimush wants to merge 2 commits into
base: main
Choose a base branch
from
Open

.NET: [Bug]: When converting from AGUIToolMessage to ChatMessage, the MessageId is lost. #4342 #4346

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
765c3fd
fix .NET: [Bug]: When converting from AGUIToolMessage to ChatMessage,…
IharYakimush Feb 27, 2026
6b0bd91
add tests for https://github.com/microsoft/agent-framework/issues/4342
IharYakimush Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion dotnet/src/Microsoft.Agents.AI.AGUI/Shared/AGUIChatMessageExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,10 @@ public static IEnumerable<ChatMessage> AsChatMessages(
new FunctionResultContent(
toolMessage.ToolCallId,
result)
]);
])
{
MessageId = message.Id
};
break;
}

Expand Down
8 changes: 6 additions & 2 deletions dotnet/tests/Microsoft.Agents.AI.AGUI.UnitTests/AGUIChatMessageExtensionsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,18 +102,20 @@ public void AsChatMessages_MapsAllSupportedRoleTypes_Correctly()
new AGUISystemMessage { Id = "msg1", Content = "System message" },
new AGUIUserMessage { Id = "msg2", Content = "User message" },
new AGUIAssistantMessage { Id = "msg3", Content = "Assistant message" },
new AGUIDeveloperMessage { Id = "msg4", Content = "Developer message" }
new AGUIDeveloperMessage { Id = "msg4", Content = "Developer message" },
new AGUIToolMessage { Id = "msg5", Content = "Tool message" }
];

// Act
List<ChatMessage> chatMessages = aguiMessages.AsChatMessages(AGUIJsonSerializerContext.Default.Options).ToList();

// Assert
Assert.Equal(4, chatMessages.Count);
Assert.Equal(5, chatMessages.Count);
Assert.Equal(ChatRole.System, chatMessages[0].Role);
Assert.Equal(ChatRole.User, chatMessages[1].Role);
Assert.Equal(ChatRole.Assistant, chatMessages[2].Role);
Assert.Equal("developer", chatMessages[3].Role.Value);
Assert.Equal(ChatRole.Tool, chatMessages[4].Role);
}

[Fact]
Expand Down Expand Up @@ -192,6 +194,7 @@ public void AsAGUIMessages_PreservesMessageId_WhenPresent()
[InlineData(AGUIRoles.User, "user")]
[InlineData(AGUIRoles.Assistant, "assistant")]
[InlineData(AGUIRoles.Developer, "developer")]
[InlineData(AGUIRoles.Tool, "tool")]
public void MapChatRole_WithValidRole_ReturnsCorrectChatRole(string aguiRole, string expectedRoleValue)
{
// Arrange & Act
Expand Down Expand Up @@ -283,6 +286,7 @@ public void AsChatMessages_WithToolMessage_DeserializesResultCorrectly()
// Assert
ChatMessage message = Assert.Single(chatMessages);
Assert.Equal(ChatRole.Tool, message.Role);
Assert.Equal("msg1", message.MessageId);
FunctionResultContent result = Assert.IsType<FunctionResultContent>(message.Contents[0]);
Assert.Equal("call_abc", result.CallId);
Assert.NotNull(result.Result);
Expand Down