Use OS trustore for certificate resolution #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
|
I believe this would make artifacts-keyring dependent on python>3.10? |
|
I'll take a look at this for the upcoming 1.0.0rc releases so we can get #83 fixed relevant doc: https://pip.pypa.io/en/latest/topics/https-certificates/ |
|
Following up on this - I'd like to get this in after our initial rc0 release so we can validate incrementally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am sitting behind a proxy inside of a corporate environment. To access any remote website, I have to use the system truststore. This PR adds this feature to the package using the truststore package. This should also resolve #83