Add CI gate check for conditional jobs#621
Merged
IEvangelist merged 1 commit intomainfrom Mar 26, 2026
Merged
Conversation
Add an always-run ci-gate job that verifies conditional jobs either ran successfully or were intentionally skipped. This gives branch protection a single stable check to require while preserving the existing conditional workflow behavior. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a single “fan-in” job (ci-gate) to provide one stable, always-created status check for GitHub rulesets/branch protection, while keeping the existing conditional jobs (frontend-build, apphost-build, integration-test) conditional.
Changes:
- Introduce an always-run
ci-gatejob that depends on all conditional jobs. - Have
ci-gatevalidate (vianeeds.*.result) that conditional jobs either succeeded when they should run, or were skipped when they should not run. - Enable requiring just
ci-gateas the protected-branch status check instead of multiple conditional checks.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
adamint
approved these changes
Mar 26, 2026
| exit 1 | ||
| fi | ||
|
|
||
| if [[ "$FRONTEND_CHANGED" == "true" ]]; then |
Member
There was a problem hiding this comment.
is there not a more efficient way of structuring these?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ci-gatejob to fan in conditional CI resultsfrontend-build,apphost-build, andintegration-testconditionalWhy
Skipped jobs already complete successfully, but a single gate check makes branch protection configuration simpler and avoids requiring multiple conditional jobs directly.
After merging, update the repo ruleset to require
ci-gateinstead of the individual conditional checks.