Skip to content

Refine CI gate workflow coverage#624

Merged
IEvangelist merged 2 commits intomainfrom
dapine/fix-ci-gate-change-detection
Mar 27, 2026
Merged

Refine CI gate workflow coverage#624
IEvangelist merged 2 commits intomainfrom
dapine/fix-ci-gate-change-detection

Conversation

@IEvangelist
Copy link
Copy Markdown
Member

Summary

  • make the CI change detector treat workflow file changes as affecting both frontend and apphost validation
  • include src/statichost in apphost change detection because AppHost builds StaticHost transitively
  • remove the duplicate integration workflow and fold its dist/index.html assertion into frontend-build
  • simplify ci-gate so it only validates the jobs that provide distinct coverage

Why

The required ci-gate check could report success without exercising the workflows it depended on. A pull request that only changed files under .github/workflows could skip frontend-build and apphost-build while still passing ci-gate.

There was a second gap for src/statichost changes. AppHost references StaticHost directly, so those changes should be treated as apphost-affecting work.

The old integration workflow was also mostly duplicating frontend-build and apphost-build. It rebuilt both sides from source, did not consume artifacts from the other jobs, and did not perform a real smoke or integration check.

Testing

  • validated .github/workflows/ci.yml and .github/workflows/frontend-build.yml after the edits
  • ran git diff --check to verify the final diff is clean

Copilot AI review requested due to automatic review settings March 27, 2026 00:12
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR tightens the CI gating logic so that changes to GitHub Actions workflows (and src/statichost) correctly trigger the relevant validation jobs, and removes a largely-duplicative integration workflow in favor of consolidating its only unique assertion into the frontend build.

Changes:

  • Update CI change detection to treat .github/workflows/** edits as affecting both frontend-build and apphost-build, and include src/statichost as apphost-affecting.
  • Remove the integration.yml workflow and the corresponding integration-test job from ci.yml.
  • Add a dist/index.html existence check to frontend-build.yml to preserve the one unique validation previously performed in integration.yml.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
.github/workflows/integration.yml Removed duplicate workflow (frontend+apphost rebuild + index.html check).
.github/workflows/frontend-build.yml Adds dist/index.html assertion after the build.
.github/workflows/ci.yml Improves change detection (workflow + statichost), and simplifies ci-gate dependencies by dropping the removed integration job.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: David Pine <david.pine@microsoft.com>
@IEvangelist IEvangelist enabled auto-merge (squash) March 27, 2026 14:37
@IEvangelist IEvangelist merged commit cf0a857 into main Mar 27, 2026
5 checks passed
@IEvangelist IEvangelist deleted the dapine/fix-ci-gate-change-detection branch March 27, 2026 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants