Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tightens the CI gating logic so that changes to GitHub Actions workflows (and src/statichost) correctly trigger the relevant validation jobs, and removes a largely-duplicative integration workflow in favor of consolidating its only unique assertion into the frontend build.
Changes:
- Update CI change detection to treat
.github/workflows/**edits as affecting bothfrontend-buildandapphost-build, and includesrc/statichostas apphost-affecting. - Remove the
integration.ymlworkflow and the correspondingintegration-testjob fromci.yml. - Add a
dist/index.htmlexistence check tofrontend-build.ymlto preserve the one unique validation previously performed inintegration.yml.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/integration.yml | Removed duplicate workflow (frontend+apphost rebuild + index.html check). |
| .github/workflows/frontend-build.yml | Adds dist/index.html assertion after the build. |
| .github/workflows/ci.yml | Improves change detection (workflow + statichost), and simplifies ci-gate dependencies by dropping the removed integration job. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
eerhardt
approved these changes
Mar 27, 2026
IEvangelist
commented
Mar 27, 2026
Co-authored-by: David Pine <david.pine@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The required ci-gate check could report success without exercising the workflows it depended on. A pull request that only changed files under .github/workflows could skip frontend-build and apphost-build while still passing ci-gate.
There was a second gap for src/statichost changes. AppHost references StaticHost directly, so those changes should be treated as apphost-affecting work.
The old integration workflow was also mostly duplicating frontend-build and apphost-build. It rebuilt both sides from source, did not consume artifacts from the other jobs, and did not perform a real smoke or integration check.
Testing