-
Notifications
You must be signed in to change notification settings - Fork 850
Add Windows CLI starter validation #15455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+552
−3
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
a78576a
Add Windows CLI starter validation\n\nCo-authored-by: Copilot <223556…
sebastienros f70be28
Cap CLI validation job runtime\n\nCo-authored-by: Copilot <223556219+…
sebastienros 78f87ac
Skip Windows CI certificate trust\n\nCo-authored-by: Copilot <2235562…
sebastienros d38faa6
Fix TS starter resource names in CI\n\nCo-authored-by: Copilot <22355…
sebastienros 943e209
Show resources before waiting in CI\n\nCo-authored-by: Copilot <22355…
sebastienros ff5666f
Tighten CLI starter validation cleanup\n\nCo-authored-by: Copilot <22…
sebastienros f88d0be
Address PR review feedback
sebastienros 95bce36
Fix certificate tests for Windows CI
sebastienros 63ff700
Add Windows ARM starter validation
sebastienros c5f81e1
Merge branch 'main' into sebros/cli-startup-check-main
sebastienros 873d102
Increase Windows ARM validation timeout
sebastienros File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,267 @@ | ||
| #!/usr/bin/env pwsh | ||
|
|
||
| [CmdletBinding()] | ||
| param( | ||
| [Parameter(Mandatory = $true, HelpMessage = "Pull request number used to select the PR dogfood channel")] | ||
| [ValidateRange(1, [int]::MaxValue)] | ||
| [int]$PRNumber, | ||
|
|
||
| [Parameter(HelpMessage = "Maximum number of seconds allowed for aspire start to complete")] | ||
| [ValidateRange(1, [int]::MaxValue)] | ||
| [int]$MaxStartupSeconds = 120, | ||
|
|
||
| [Parameter(HelpMessage = "Maximum number of seconds to wait for each expected resource to reach the requested status")] | ||
| [ValidateRange(1, [int]::MaxValue)] | ||
| [int]$ResourceReadyTimeoutSeconds = 120, | ||
|
|
||
| [Parameter(HelpMessage = "Directory used to store starter validation projects and diagnostics")] | ||
| [string]$ValidationRoot = "" | ||
| ) | ||
|
|
||
| $ErrorActionPreference = 'Stop' | ||
| $PSNativeCommandUseErrorActionPreference = $true | ||
| Set-StrictMode -Version Latest | ||
|
|
||
| function Get-ValidationRoot | ||
| { | ||
| if (-not [string]::IsNullOrWhiteSpace($ValidationRoot)) | ||
| { | ||
| return $ValidationRoot | ||
| } | ||
|
|
||
| if (-not [string]::IsNullOrWhiteSpace($env:RUNNER_TEMP)) | ||
| { | ||
| return (Join-Path $env:RUNNER_TEMP 'aspire-cli-starter-validation') | ||
| } | ||
|
|
||
| return (Join-Path ([System.IO.Path]::GetTempPath()) 'aspire-cli-starter-validation') | ||
| } | ||
|
|
||
| function Get-FileContentOrEmpty | ||
| { | ||
| param( | ||
| [Parameter(Mandatory = $true)] | ||
| [string]$Path | ||
| ) | ||
|
|
||
| if (Test-Path $Path) | ||
| { | ||
| return (Get-Content -Raw $Path) | ||
| } | ||
|
|
||
| return '' | ||
| } | ||
|
|
||
| function Get-CombinedProcessOutput | ||
| { | ||
| param( | ||
| [Parameter(Mandatory = $true)] | ||
| [string]$StdOutPath, | ||
|
|
||
| [Parameter(Mandatory = $true)] | ||
| [string]$StdErrPath | ||
| ) | ||
|
|
||
| $stdout = Get-FileContentOrEmpty -Path $StdOutPath | ||
| $stderr = Get-FileContentOrEmpty -Path $StdErrPath | ||
|
|
||
| if ($stdout -and $stderr) | ||
| { | ||
| return ($stdout, $stderr) -join [Environment]::NewLine | ||
| } | ||
|
|
||
| return "$stdout$stderr" | ||
| } | ||
|
|
||
| $validationRootPath = Get-ValidationRoot | ||
| Remove-Item -Recurse -Force $validationRootPath -ErrorAction SilentlyContinue | ||
| New-Item -ItemType Directory -Path $validationRootPath -Force | Out-Null | ||
|
|
||
| $templates = @( | ||
| @{ | ||
| TemplateId = 'aspire-ts-starter' | ||
| ProjectName = 'AspireCliTsStarterSmoke' | ||
| ExpectedResources = @('app', 'frontend') | ||
| }, | ||
| @{ | ||
| TemplateId = 'aspire-starter' | ||
| ProjectName = 'AspireCliCsStarterSmoke' | ||
| ExpectedResources = @('apiservice') | ||
| } | ||
| ) | ||
|
|
||
| $failures = [System.Collections.Generic.List[string]]::new() | ||
|
|
||
| foreach ($template in $templates) | ||
| { | ||
| $templateId = [string]$template.TemplateId | ||
| $projectName = [string]$template.ProjectName | ||
| $expectedResources = @($template.ExpectedResources) | ||
| $templateRoot = Join-Path $validationRootPath $templateId | ||
| $diagnosticsDir = Join-Path $templateRoot 'diagnostics' | ||
| $projectRoot = Join-Path $templateRoot $projectName | ||
| $startStdOutPath = Join-Path $diagnosticsDir 'aspire-start.stdout.log' | ||
| $startStdErrPath = Join-Path $diagnosticsDir 'aspire-start.stderr.log' | ||
| $startCombinedPath = Join-Path $diagnosticsDir 'aspire-start.log' | ||
| $preStartStopLogPath = Join-Path $diagnosticsDir 'aspire-stop-before-start.log' | ||
| $stopLogPath = Join-Path $diagnosticsDir 'aspire-stop.log' | ||
|
|
||
| New-Item -ItemType Directory -Path $templateRoot -Force | Out-Null | ||
| New-Item -ItemType Directory -Path $diagnosticsDir -Force | Out-Null | ||
|
|
||
| Push-Location $templateRoot | ||
| try | ||
| { | ||
| try | ||
| { | ||
| aspire new $templateId --name $projectName --output $projectRoot --channel "pr-$PRNumber" --non-interactive --nologo | ||
|
|
||
| try | ||
| { | ||
| aspire stop *> $preStartStopLogPath | ||
| } | ||
| catch | ||
| { | ||
| $preStartStopOutput = Get-FileContentOrEmpty -Path $preStartStopLogPath | ||
| if ($preStartStopOutput -notmatch 'No running apphost found\.') | ||
| { | ||
| Write-Warning "$templateId pre-start cleanup with aspire stop failed: $($_.Exception.Message)" | ||
| if ($preStartStopOutput) | ||
| { | ||
| Write-Host $preStartStopOutput | ||
| } | ||
| } | ||
| } | ||
|
|
||
| $startAt = Get-Date | ||
| $process = Start-Process -FilePath 'aspire' ` | ||
| -ArgumentList @('start') ` | ||
| -WorkingDirectory $projectRoot ` | ||
| -RedirectStandardOutput $startStdOutPath ` | ||
| -RedirectStandardError $startStdErrPath ` | ||
| -PassThru | ||
|
|
||
| try | ||
| { | ||
| $process | Wait-Process -Timeout $MaxStartupSeconds -ErrorAction Stop | ||
| } | ||
| catch | ||
| { | ||
| if (-not $process.HasExited) | ||
| { | ||
| $process | Stop-Process -Force -ErrorAction SilentlyContinue | ||
| } | ||
|
|
||
| throw "${templateId}: aspire start did not exit within $MaxStartupSeconds seconds." | ||
| } | ||
|
|
||
| $elapsed = (Get-Date) - $startAt | ||
| $startOutput = Get-CombinedProcessOutput -StdOutPath $startStdOutPath -StdErrPath $startStdErrPath | ||
|
|
||
| Set-Content -Path $startCombinedPath -Value $startOutput | ||
|
|
||
| if ($process.ExitCode -ne 0) | ||
| { | ||
| throw "${templateId}: aspire start failed with exit code $($process.ExitCode)." | ||
| } | ||
|
|
||
| if ($startOutput -match 'Timeout waiting for apphost to start') | ||
| { | ||
| throw "${templateId}: aspire start reported a startup timeout." | ||
| } | ||
|
|
||
| if ($startOutput -notmatch 'Apphost started successfully\.') | ||
| { | ||
| throw "${templateId}: aspire start did not report a successful startup." | ||
| } | ||
|
|
||
| Set-Location $projectRoot | ||
|
|
||
| $resourcesStdOutPath = Join-Path $diagnosticsDir 'aspire-resources.stdout.log' | ||
| $resourcesStdErrPath = Join-Path $diagnosticsDir 'aspire-resources.stderr.log' | ||
| $resourcesCombinedPath = Join-Path $diagnosticsDir 'aspire-resources.log' | ||
|
|
||
| $resourcesProcess = Start-Process -FilePath 'aspire' ` | ||
| -ArgumentList @('resources') ` | ||
| -WorkingDirectory $projectRoot ` | ||
| -RedirectStandardOutput $resourcesStdOutPath ` | ||
| -RedirectStandardError $resourcesStdErrPath ` | ||
| -Wait ` | ||
| -PassThru | ||
|
|
||
| $resourcesOutput = Get-CombinedProcessOutput -StdOutPath $resourcesStdOutPath -StdErrPath $resourcesStdErrPath | ||
|
|
||
| Set-Content -Path $resourcesCombinedPath -Value $resourcesOutput | ||
| Write-Host $resourcesOutput | ||
|
|
||
| if ($resourcesProcess.ExitCode -ne 0) | ||
| { | ||
| throw "${templateId}: aspire resources failed with exit code $($resourcesProcess.ExitCode)." | ||
| } | ||
|
|
||
| foreach ($resourceName in $expectedResources) | ||
| { | ||
| $sanitizedResourceName = $resourceName -replace '[^A-Za-z0-9_.-]', '_' | ||
| $waitStdOutPath = Join-Path $diagnosticsDir "aspire-wait-${sanitizedResourceName}.stdout.log" | ||
| $waitStdErrPath = Join-Path $diagnosticsDir "aspire-wait-${sanitizedResourceName}.stderr.log" | ||
| $waitCombinedPath = Join-Path $diagnosticsDir "aspire-wait-${sanitizedResourceName}.log" | ||
|
|
||
| $waitProcess = Start-Process -FilePath 'aspire' ` | ||
| -ArgumentList @('wait', $resourceName, '--status', 'up', '--timeout', $ResourceReadyTimeoutSeconds) ` | ||
| -WorkingDirectory $projectRoot ` | ||
| -RedirectStandardOutput $waitStdOutPath ` | ||
| -RedirectStandardError $waitStdErrPath ` | ||
| -Wait ` | ||
| -PassThru | ||
|
|
||
| $waitOutput = Get-CombinedProcessOutput -StdOutPath $waitStdOutPath -StdErrPath $waitStdErrPath | ||
|
|
||
| Set-Content -Path $waitCombinedPath -Value $waitOutput | ||
|
|
||
| if ($waitProcess.ExitCode -ne 0) | ||
| { | ||
| throw "${templateId}: aspire wait for resource $resourceName failed with exit code $($waitProcess.ExitCode)." | ||
| } | ||
| } | ||
|
|
||
| Write-Host "$templateId started in $([math]::Round($elapsed.TotalSeconds, 2)) seconds." | ||
| } | ||
| catch | ||
| { | ||
| $message = $_.Exception.Message | ||
| Write-Warning $message | ||
| $failures.Add($message) | ||
| } | ||
| } | ||
| finally | ||
| { | ||
| if (Test-Path $projectRoot) | ||
| { | ||
| Push-Location $projectRoot | ||
| try | ||
| { | ||
| aspire stop *> $stopLogPath | ||
| } | ||
| catch | ||
| { | ||
| Write-Warning "$templateId cleanup with aspire stop failed: $($_.Exception.Message)" | ||
| $stopOutput = Get-FileContentOrEmpty -Path $stopLogPath | ||
| if ($stopOutput) | ||
| { | ||
| Write-Host $stopOutput | ||
| } | ||
| } | ||
| finally | ||
| { | ||
| Pop-Location | ||
| } | ||
| } | ||
|
|
||
| Pop-Location | ||
| } | ||
| } | ||
|
|
||
| if ($failures.Count -gt 0) | ||
| { | ||
| throw ("Starter validation failures:`n- " + ($failures -join "`n- ")) | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.