Skip to content

Conversation

@AZaugg
Copy link
Contributor

@AZaugg AZaugg commented Dec 11, 2025

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

When building mtr with pkgconfig we are getting missmatched ABI pairing betweeen ncursesw tinfo during build time force the correct ABI pair and dont confuse v5 and v6 ncurse versions

Change Log
  • Fixes mtr segfaut
Does this affect the toolchain?

NO

Associated issues
Test Methodology

https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1002606&view=results

Ran mtr, before change

$ mtr
Segmentation fault (core dumped)
root [ /usr/src/azl/SPECS ]# ldd /sbin/mtr|grep -E  'libtinfo|libncurses'
	libncursesw.so.6 => /usr/lib/libncursesw.so.6 (0x00007fea457b1000)
	libtinfo.so.6 => /usr/lib/libtinfo.so.6 (0x00007fea4577c000)
root [ /usr/src/azl/SPECS ]#

After change, mtr runs

@AZaugg AZaugg requested a review from a team as a code owner December 11, 2025 16:41
@AZaugg AZaugg changed the base branch from 3.0 to 3.0-dev December 11, 2025 16:51
@microsoft-github-policy-service microsoft-github-policy-service bot added the 3.0-dev PRs Destined for AzureLinux 3.0 label Dec 11, 2025
When building mtr with pkgconfig we are getting missmatched ABI pairing
betweeen ncursesw tinfo during build time force the correct ABI pair
and dont confuse v5 and v6 ncurse versions
@AZaugg AZaugg force-pushed the mtr-segmentation-fault-fix-15286 branch from 4103dfe to 23b1d7e Compare December 11, 2025 17:11
Co-authored-by: Christopher Co <35273088+christopherco@users.noreply.github.com>
%{_datadir}/bash-completion/completions/%{name}

%changelog
* Thu Dev 11 2025 Andy Zaugg <azaugg@linkedin.com> - 0.95-4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Triggered a test build:

Thanks @AZaugg

Copy link
Member

@mfrw mfrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Test build passed.

Copy link
Member

@mfrw mfrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified in a test VM:

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.0-dev PRs Destined for AzureLinux 3.0 3.0 PRs Destined for 3.0 Packaging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants