-
Notifications
You must be signed in to change notification settings - Fork 602
fix mtr segfault #15287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 3.0-dev
Are you sure you want to change the base?
fix mtr segfault #15287
Conversation
When building mtr with pkgconfig we are getting missmatched ABI pairing betweeen ncursesw tinfo during build time force the correct ABI pair and dont confuse v5 and v6 ncurse versions
4103dfe to
23b1d7e
Compare
Co-authored-by: Christopher Co <35273088+christopherco@users.noreply.github.com>
| %{_datadir}/bash-completion/completions/%{name} | ||
|
|
||
| %changelog | ||
| * Thu Dev 11 2025 Andy Zaugg <azaugg@linkedin.com> - 0.95-4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mfrw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Test build passed.
mfrw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.

Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./LICENSES-AND-NOTICES/SPECS/data/licenses.json,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
When building mtr with pkgconfig we are getting missmatched ABI pairing betweeen ncursesw tinfo during build time force the correct ABI pair and dont confuse v5 and v6 ncurse versions
Change Log
Does this affect the toolchain?
NO
Associated issues
Test Methodology
https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1002606&view=results
Ran mtr, before change
After change, mtr runs