Skip to content

Upgrade ibus-table version to 1.17.16 #15302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kgodara912 merged 2 commits into from
Dec 19, 2025
Merged

Upgrade ibus-table version to 1.17.16 #15302

kgodara912 merged 2 commits into from
Dec 19, 2025

Conversation

@v-aaditya
Copy link
Contributor

@v-aaditya v-aaditya commented Dec 16, 2025 •
edited
Loading

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge
Summary
  • Upgrade ibus-table version to 1.17.16.
  • This PR also fixes "ibus-table-chinese" package build, which has been verified by building it along with "ibus-table" package.
Build/Dependency Information

Please build the following packages with ibus-table:
"cmake-fedora ibus-table-chinese cldr-emoji-annotation iso-codes libdbusmenu unicode-emoji unicode-ucd ibus"

Change Log
  • modified: cgmanifest.json
  • modified: SPECS-EXTENDED/ibus-table/ibus-table.spec
  • modified: SPECS-EXTENDED/ibus-table/ibus-table.signatures.json
Does this affect the toolchain?

NO

Test Methodology
image
  • Uninstallation Check
image

@microsoft-github-policy-service microsoft-github-policy-service bot added Packaging specs-extended PR to fix SPECS-EXTENDED 3.0-dev PRs Destined for AzureLinux 3.0 labels Dec 16, 2025
@v-aaditya v-aaditya marked this pull request as ready for review December 17, 2025 05:13
@v-aaditya v-aaditya requested review from a team as code owners December 17, 2025 05:13
@v-aaditya v-aaditya force-pushed the topic_ibus-table-3.0 branch from 708af8b to 8109143 Compare December 18, 2025 06:19
@v-aaditya v-aaditya changed the title Upgrade ibus-table version to 1.17.16 and built ibus-table-chinese Upgrade ibus-table version to 1.17.16 Dec 18, 2025
@sandeepkarambelkar
Copy link
Contributor

sandeepkarambelkar commented Dec 18, 2025

Buddy Build - https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1007388&view=results

@v-aaditya
Copy link
Contributor Author

v-aaditya commented Dec 18, 2025 •
edited
Loading

Buddy Build - https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1007388&view=results

Buddy Build has passed, but there are license check warning issues.

Out of 4 packages which are giving this issue, I have addressed the issue only in "ibus-table" and "ibus-table-chinese", other 2 are dependency packages, so I did not touch them.

@v-aaditya v-aaditya force-pushed the topic_ibus-table-3.0 branch 2 times, most recently from 9af21b1 to 456d22d Compare December 18, 2025 10:43
@v-aaditya v-aaditya force-pushed the topic_ibus-table-3.0 branch from 456d22d to bffd83b Compare December 19, 2025 05:12
@sandeepkarambelkar
Copy link
Contributor

sandeepkarambelkar commented Dec 19, 2025

Buddy Build - https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1008025&view=results

@v-aaditya
Copy link
Contributor Author

v-aaditya commented Dec 19, 2025

Buddy Build - https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1008025&view=results

The Buddy Build has passed, but with license check issue warning for 1 of the dependency packages and this dependency package is not related to ibus. PFB screenshot for reference -

image

sandeepkarambelkar
sandeepkarambelkar approved these changes Dec 19, 2025
View reviewed changes
Copy link
Contributor

@sandeepkarambelkar sandeepkarambelkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM.
Buddy build successful.

kgodara912
kgodara912 approved these changes Dec 19, 2025
View reviewed changes
Copy link
Contributor

@kgodara912 kgodara912 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Buddy build is successful. Version bump of one package and license marking correction for other two. LGTM.

@kgodara912 kgodara912 merged commit be8e809 into microsoft:3.0-dev Dec 19, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sandeepkarambelkar sandeepkarambelkar sandeepkarambelkar approved these changes

@kgodara912 kgodara912 kgodara912 approved these changes

Assignees

No one assigned

Labels

3.0-dev PRs Destined for AzureLinux 3.0 Packaging specs-extended PR to fix SPECS-EXTENDED

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@v-aaditya @sandeepkarambelkar @kgodara912