feat: add --models, --regions, and --verbose support #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Integrated a flag to enable detailed logging for easier troubleshooting.
Priyanka-Microsoft
requested review from
Avijit-Microsoft,
Prajwal-Microsoft,
Roopan-Microsoft,
Vinay-Microsoft and
aniaroramsft
as code owners
Prajwal-Microsoft
approved these changes
Apr 14, 2025
|
🎉 This PR is included in version 1.1.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Prajwal-Microsoft
deleted the
enhancement/azure-script-verbose-model-region-params
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request introduces significant enhancements to the
infra/scripts/quota_check_params.shscript, focusing on adding verbosity control, improving parameter handling, and refining logging mechanisms.Key changes include:
Verbosity Control:
--verboseflag to enable detailed logging. Added alog_verbosefunction to conditionally output logs based on the verbosity flag. [1] [2]Parameter Handling:
--models,--regions, and--verboseoptions, with fallback to defaults if not provided. [1] [2]Logging Enhancements:
echostatements withlog_verbosecalls to ensure logs are only printed when verbosity is enabled. This change affects multiple sections of the script, including region and model checks. [1] [2] [3] [4] [5]These updates improve the script's usability and maintainability by providing more control over logging and enhancing parameter flexibility.
Does this introduce a breaking change?
No
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information