Remove compiled files so we can generate them ourselves #1723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamYoblick
reviewed
Nov 5, 2024
|
|
||
| # C extensions | ||
| *.so | ||
| *.dylib |
Contributor
There was a problem hiding this comment.
I'm not sure if there are any other files with these extensions in our repo. Should we consider explicitly excluding these files from src\debugpy\_vendored\pydevd\pydevd_attach_to_process ?
Contributor
Author
There was a problem hiding this comment.
There isn't any but I think we shouldn't ever be checking in dlls/exes. Too opaque.
AdamYoblick
approved these changes
Nov 5, 2024
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
Can you just submit this Adam? It's not performing the license test for some reason |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
Okay the 3.13 tests all passed locally with the same binaries as built by the PR. Submitting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing all of the compiled dlls for attach so we can generate them ourselves.