Skip to content

Fix Power BI "Number of Months" parameter causing incorrect date range calculation #1852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: dev
Choose a base branch
from
Draft

Fix Power BI "Number of Months" parameter causing incorrect date range calculation #1852

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
306a962
Initial plan
Copilot Oct 10, 2025
e0f8403
Fix Number of Months date calculation bug
Copilot Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs-mslearn/toolkit/changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ The following section lists features and enhancements that are currently in deve

- **Fixed**
- Fixed tag expansion in Power BI reports when tag names contain special characters like colons.
- Fixed "Number of Months" parameter calculation that was excluding the first 5 days of data when set to 3 months ([#1833](https://github.com/microsoft/finops-toolkit/issues/1833)).

### [FinOps hubs](hubs/finops-hubs-overview.md) v13

Expand Down
2 changes: 1 addition & 1 deletion src/power-bi/kql/Shared.Dataset/definition/expressions.tmdl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ expression '▶️ START HERE' = ```
DateEnd = null,
DateStart = null,
DateMonths = #"Number of Months",
DateStartEffective = if DateStart <> null and DateStart <> "" then DateStart else Date.AddMonths(if DateEnd <> null and DateEnd <> "" then DateEnd else Date.AddMonths(Date.StartOfMonth(DateTime.LocalNow()), 1), -DateMonths+1),
DateStartEffective = if DateStart <> null and DateStart <> "" then DateStart else Date.AddMonths(if DateEnd <> null and DateEnd <> "" then DateEnd else Date.AddMonths(Date.StartOfMonth(DateTime.LocalNow()), 1), -DateMonths),
_formatDate = (d) => try DateTime.ToText(d, [Format="MMM d, yyyy"]) otherwise d,
DateStartFormat =
if (DateStart = null or DateStart = "") and (DateMonths = null or DateMonths < 1) then "*"
Expand Down
2 changes: 1 addition & 1 deletion src/power-bi/kql/Shared.Dataset/definition/tables/StorageData.tmdl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,7 @@ table StorageData
end = if RangeEnd <> null then Date.From(RangeEnd, Culture.Current) else null,
start =
if RangeStart <> null then Date.From(RangeStart, Culture.Current)
else if #"Number of Months" <> null and #"Number of Months" > 0 then Date.AddMonths(if end <> null then end else Date.StartOfMonth(Date.From(DateTime.LocalNow())), -(#"Number of Months"+1))
else if #"Number of Months" <> null and #"Number of Months" > 0 then Date.AddMonths(if end <> null then end else Date.StartOfMonth(Date.From(DateTime.LocalNow())), -#"Number of Months")
else null,
FilterFilesByDate =
if start = null and end = null then InitialDetails
Expand Down
4 changes: 2 additions & 2 deletions src/power-bi/storage/Shared.Dataset/definition/expressions.tmdl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ expression '▶️ START HERE' = ```
DateEnd = RangeEnd,
DateStart = RangeStart,
DateMonths = #"Number of Months",
DateStartEffective = if DateStart <> null and DateStart <> "" then DateStart else Date.AddMonths(if DateEnd <> null and DateEnd <> "" then DateEnd else Date.AddMonths(Date.StartOfMonth(DateTime.LocalNow()), 1), -DateMonths+1),
DateStartEffective = if DateStart <> null and DateStart <> "" then DateStart else Date.AddMonths(if DateEnd <> null and DateEnd <> "" then DateEnd else Date.AddMonths(Date.StartOfMonth(DateTime.LocalNow()), 1), -DateMonths),
_formatDate = (d) => try DateTime.ToText(d, [Format="MMM d, yyyy"]) otherwise d,
DateStartFormat =
if (DateStart = null or DateStart = "") and (DateMonths = null or DateMonths < 1) then "*"
Expand Down Expand Up @@ -127,7 +127,7 @@ expression ftk_Storage = ```
end = if RangeEnd <> null then Date.From(RangeEnd, Culture.Current) else null,
start =
if RangeStart <> null then Date.From(RangeStart, Culture.Current)
else if #"Number of Months" <> null and #"Number of Months" > 0 then Date.AddMonths(if end <> null then end else Date.StartOfMonth(Date.From(DateTime.LocalNow())), -(#"Number of Months"+1))
else if #"Number of Months" <> null and #"Number of Months" > 0 then Date.AddMonths(if end <> null then end else Date.StartOfMonth(Date.From(DateTime.LocalNow())), -#"Number of Months")
else null,
data = if datasetType <> null and datasetType <> "" then Text.Lower(datasetType) else "focuscost",

Expand Down
2 changes: 1 addition & 1 deletion src/power-bi/storage/Shared.Dataset/definition/tables/StorageData.tmdl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,7 @@ table StorageData
end = if RangeEnd <> null then Date.From(RangeEnd, Culture.Current) else null,
start =
if RangeStart <> null then Date.From(RangeStart, Culture.Current)
else if #"Number of Months" <> null and #"Number of Months" > 0 then Date.AddMonths(if end <> null then end else Date.StartOfMonth(Date.From(DateTime.LocalNow())), -(#"Number of Months"+1))
else if #"Number of Months" <> null and #"Number of Months" > 0 then Date.AddMonths(if end <> null then end else Date.StartOfMonth(Date.From(DateTime.LocalNow())), -#"Number of Months")
else null,
FilterFilesByDate =
if start = null and end = null then InitialDetails
Expand Down