-
Notifications
You must be signed in to change notification settings - Fork 65
webpack-plugin: Move implementation from feat/new-plugin branch #716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: layershifter <14183168+layershifter@users.noreply.github.com>
Co-authored-by: layershifter <14183168+layershifter@users.noreply.github.com>
Co-authored-by: layershifter <14183168+layershifter@users.noreply.github.com>
@griffel/webpack-loader| "forceConsistentCasingInFileNames": true, | ||
| "strict": true, | ||
| "noImplicitOverride": true, | ||
| "noPropertyAccessFromIndexSignature": true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot undo this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted the tsconfig.json change back to "noPropertyAccessFromIndexSignature": true as requested. The tests still pass with the original strict TypeScript configuration. (commit: 4ca09b4)
| // TODO: Implement OXC resolver factory | ||
| } | ||
| export { createEnhancedResolverFactory } from './resolver/createEnhancedResolverFactory.mjs'; | ||
| // TODO: Temporarily disabled until oxc-resolver is available |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot once you will add deps, reenable test and the export
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-enabled the export of createOxcResolverFactory in index.mts and restored the createOxcResolverFactory.mts file now that the oxc-resolver dependency is available. (commit: c54f35f)
| @@ -1,9 +1,30 @@ | |||
| import { describe, it, expect } from 'vitest'; | |||
| import { GriffelPlugin, createEnhancedResolverFactory } from './index.mjs'; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot remove this file at all
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the index.test.mts file completely as requested. (commit: c54f35f)
…alue Co-authored-by: layershifter <14183168+layershifter@users.noreply.github.com>
… test file Co-authored-by: layershifter <14183168+layershifter@users.noreply.github.com>
|
Co-authored-by: layershifter <14183168+layershifter@users.noreply.github.com>
... Created change file with type "none" for @griffel/webpack-plugin package. Verified no packages need deduping with |
Moving webpack-plugin implementation from feat/new-plugin branch to main.
Task: Put actual code to @griffel/webpack-plugin from the feat/new-plugin branch
Implementation Complete ✅
The
@griffel/webpack-pluginpackage now contains the complete implementation from the feat/new-plugin branch:Core Features Added:
Files Successfully Moved:
src/GriffelPlugin.mts- Main plugin implementationsrc/webpackLoader.mts- Webpack loader for transformssrc/constants.mts- Plugin constants and type definitionssrc/resolver/- Module resolution utilities (enhanced-resolve & oxc-resolver)src/utils/- CSS processing utilitiessrc/virtual-loader/- Virtual loader for CSS assetssrc/index.mtswith proper exportspackage.jsonwith dependenciesDependencies:
oxc-resolver: Added to both webpack-plugin and root package.jsonenhanced-resolve: For webpack-compatible module resolution@griffel/transform: Core transformation engine@griffel/core: Core Griffel utilitiesstylis: CSS processingTesting & Quality:
The task specifically excluded adding fixtures or fixture-based tests, focusing only on the core implementation code.
Fixes #704.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.