-
Couldn't load subscription status.
- Fork 219
Add UnifiedMessage support for NetworkUDPPerformanceMessage in iperf3 #4059
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: squirrelsc <27178119+squirrelsc@users.noreply.github.com>
Co-authored-by: squirrelsc <27178119+squirrelsc@users.noreply.github.com>
|
@copilot fix check errors. |
Co-authored-by: squirrelsc <27178119+squirrelsc@users.noreply.github.com>
…description Co-authored-by: squirrelsc <27178119+squirrelsc@users.noreply.github.com>
|
Fix check errors and comments. @copilot |
Co-authored-by: squirrelsc <27178119+squirrelsc@users.noreply.github.com>
lisa/tools/iperf3.py
Outdated
| { | ||
| "name": "send_buffer_size", | ||
| "value": float(send_buffer_size), | ||
| "relativity": MetricRelativity.NA, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its type should be Parameter? @copilot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct! Changed send_buffer_size to Parameter type. Now both connections_num and send_buffer_size are sent as separate Parameter type unified messages (marked via metric_description="Parameter"), while tx_throughput, rx_throughput, and data_loss are sent as performance metrics. Commit: e6fb706
lisa/tools/iperf3.py
Outdated
| ) -> None: | ||
| """Send unified performance messages for UDP iperf3 metrics.""" | ||
| # Send connections_num as a Parameter type metric | ||
| send_unified_perf_message( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add it in the metrics array and send together. @copilot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added parameters to the metrics array. Now all parameters (connections_num, send_buffer_size) and performance metrics (tx_throughput, rx_throughput, data_loss) are in a single array and sent together in one loop. Commit: 5e58cd1
Co-authored-by: squirrelsc <27178119+squirrelsc@users.noreply.github.com>
Co-authored-by: squirrelsc <27178119+squirrelsc@users.noreply.github.com>
Summary:
Added UnifiedMessage support for NetworkUDPPerformanceMessage in iperf3.py. The implementation:
Implementation approach:
Original prompt
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.