Fix false positives in kernel panic detection #4071
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squirrelsc
reviewed
Oct 24, 2025
squirrelsc
reviewed
Oct 24, 2025
Improve SerialConsole panic detection to eliminate false positives from harmless boot messages while maintaining strong detection of real kernel panics. Changes: - Tightened panic patterns to require specific markers: * 'Kernel panic - not syncing:', 'panic:', 'Oops:' * 'soft/hard lockup - CPU#<num> stuck' (requires CPU number) * 'rcu_sched self-detected stall' (specific RCU stall marker) - Removed overly broad patterns that caused false positives: * Generic 'watchdog' (now requires CPU# for lockup detection) * Generic 'RIP:' (stack traces are not panics) * Generic 'hung task', 'stall' (too broad) - Expanded ignore list for harmless boot messages: * 'NMI watchdog.*permanently disabled' * 'Perf NMI watchdog permanently disabled' * Generic watchdog enabled/disabled messages * RCU grace period messages (not stalls) * hung_task_timeout_secs configuration messages This eliminates false positives like 'NMI watchdog: Perf NMI watchdog permanently disabled' while still catching real kernel crashes, lockups, and RCU stalls.
vyadavmsft
force-pushed
the
vyadav_fix_panic_handler
branch
from
8287e04 to
c1999db
Compare
|
Need to work on long term solution with vijay and other. the immediate problematic line is already addressed in other pr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is BUG Fix for SerialConsole panic detection to eliminate false positives from harmless boot messages while maintaining strong detection of real kernel panics.
Changes:
Tightened panic patterns to require specific markers:
Removed overly broad patterns that caused false positives:
Expanded ignore list for harmless boot messages:
This eliminates false positives like 'NMI watchdog: Perf NMI watchdog permanently disabled' while still catching real kernel crashes, lockups, and RCU stalls.