add security profile parsing support for marketplace image #4150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityagesh
reviewed
Dec 10, 2025
Comment on lines
+822
to
824
| f"or '<Publisher>:<Offer>:<Sku>:<Version>' " | ||
| f"or '<Publisher> <Offer> <Sku> <Version> [Profile1,Profile2]'" | ||
| ) |
Collaborator
There was a problem hiding this comment.
Is this a new pattern for images in Azure?
Collaborator
Author
There was a problem hiding this comment.
We are in discussion about this method. Maybe this PR will be abondoned
adityagesh
reviewed
Dec 10, 2025
Comment on lines
+769
to
+771
| security_profile_match = re.search(r"\[(.*?)\]$", self.marketplace_raw) | ||
| security_profile_str = None | ||
| marketplace_base = self.marketplace_raw |
Collaborator
There was a problem hiding this comment.
Can you instead use one of the utility methods in lisa/lisa/util/init.py, like find_patterns_in_lines, get_matched_str
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add security profile parsing support for marketplace image when input string,
e.g. "MicrosoftWindowsServer WindowsServer 2022-datacenter-g2 latest [secureboot]"