Phase duration #418
Open
Phase duration #418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcamachor
approved these changes
Aug 18, 2025
| } | ||
| checkResults(executor.invokeAll(threads)); | ||
| } catch (Exception e) { | ||
| LOGGER.error("Exception executing phase: " + phase.getId()); |
Contributor
There was a problem hiding this comment.
This is logged is the calling method as well, it seems this line can be removed.
| - tasks: | ||
| - template_id: build | ||
| - id: single_user | ||
| minimal_duration_seconds: 5 |
Contributor
There was a problem hiding this comment.
This property should be added to the phase_template item in template.json for schema validation. I'm actually surprised validation doesn't fail in your test, since it goes through the FileParser.loadWorkload method, which should run validation. That likely means something isn't working correctly in the validation :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified the phase definition to allow for longer-running phases that repeatedly execute its sessions until a minimum duration has passed.