RestServer - support inference/training jobType in job protocal #105
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for job type classification in the job protocol, enabling jobs to be categorized as 'inference', 'training', or 'others'. The implementation includes validation logic for inference jobs that requires specific parameters.
Key Changes:
- Added
jobTypefield to the protocol schema with validation - Implemented validation for inference jobs requiring INTERNAL_SERVER_IP, INTERNAL_SERVER_PORT, and API_KEY parameters
- Updated job controller to tag jobs with their type
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/rest-server/src/config/v2/protocol.js | Added jobType field to protocol schema with enum constraint |
| src/rest-server/src/middlewares/v2/protocol.js | Implemented validation logic for jobType and inference job parameters |
| src/rest-server/src/controllers/v2/job.js | Added jobType extraction and job tagging |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| } | ||
| } | ||
|
|
||
| // check jobType |
There was a problem hiding this comment.
Corrected spelling of 'protocal' in PR title to 'protocol'. Note: There's a trailing space after the comment that should be removed.
| // check jobType | |
| // check jobType |
| const frameworkName = `${userName}~${jobName}`; | ||
|
|
||
| const jobType = res.locals.protocol.jobType || 'others'; | ||
|
|
There was a problem hiding this comment.
Line 204 contains trailing whitespace. Remove the trailing space to maintain code cleanliness.
yukirora
changed the title
No description provided.