Fix regex for macOS version extraction #303
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Upon a deeper look at the logic, it looks like we automatically install the latest commandline tools available if we don't find a specific one related to the os version number. What was happening here is that finding the os version was failing so that subsequent step wasn't being hit. Completing this PR should fix that and continue installing the latest commandline tools (not sure why we have the platform specific check at all but not going to address that in this PR yet) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to previous recent fixes, the new patch version of Tahoe broke the
macos_versionregex pattern. This commit fixes that, however I did notice that it would (correctly) output 26.0.1 which would not match the current Command Line Tools version of 26.0-26.0, and so would return no suggested Command Line Tool version in theplatform_specificfunction (incorrectly?).So might need to also address that logic in this PR before completion, but will defer to reviewers.