ebpf ext device name fix #260
Open
+5
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emanela
requested review from
Alan-Jowett,
LakshK98,
matthewige,
mikeagun,
mtfriesen,
poornagmsft,
saxena-anurag and
shankarseal
as code owners
device name wasn't set properly due to macro expansion behavior. Signed-off-by: Elad Manela <elad.manela@upwind.io>
emanela
force-pushed
the
ebpf_ext_device_name_fix
branch
from
91e9bb6 to
a76580d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
device name wasn't set properly due to macro expansion behavior resulting in only one ebpf extension able to be loaded at a time.
Testing
Compiled extensions with the change and verified successful installation and running status for both extensions at the same time. I also verified via WinDbg that the device name set accordingly, e.g.
\\device\\ebpf_ext_ntosand not\\device\\ebpf_ext_PROVIDER_NAMEas before.Documentation
No.
Installation
No.