Support Array Type for Tool Calling Function#1043
Merged
sayanshaw24 merged 1 commit intomainfrom Apr 7, 2026
Merged
Conversation
kunal-vaishnavi
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a crash in
ConvertParameterswhen a tool function property's"type"field is a JSON array (e.g.["string", "null"]) instead of a plain string.Per the OpenAI function calling spec, strict mode requires all fields to be marked as
required, and optional fields are denoted by adding"null"as a type option — resulting in"type": ["string", "null"]rather than"type": "string".Previously,
ConvertParametersunconditionally didstd::string type = prop_schema["type"], which throwsjson.exception.type_error.302when the value is an array. This caused a 500 error in downstream consumers like Foundry Local.Changes
shared/api/chat_template.ccConvertParametersto handle"type"as:"string"→"str", others as-is)"null"type from the array and normalizes ittest/pp_api_test/test_tokenizer_chat.ccQwen2_5_ChatTemplateWithOAIFunctionTypeArrayTypetest that uses"type": ["string", "null"]on a property, verifying it normalizes correctly without crashing.Validation
Fixes