Skip to content

Conversation

@fs-eire
Copy link
Contributor

@fs-eire fs-eire commented Oct 27, 2025

Description

[js] Upgrade ESLint from v8 to v9 for subfolder /js/

Motivation and Context

@fs-eire fs-eire requested a review from Copilot October 27, 2025 22:38
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades ESLint from version 8 to version 9 for the /js/ folder, migrating from the legacy .eslintrc.js configuration format to the new flat config format (eslint.config.mjs). The upgrade also includes updates to related ESLint plugins and adapts the codebase to comply with new linting rules.

  • Migrated ESLint configuration from .eslintrc.js to flat config format eslint.config.mjs
  • Upgraded ESLint and related plugins to their latest versions
  • Replaced deprecated expect().to.be.true/false assertions with explicit error throwing
  • Removed unnecessary ESLint disable comments that are no longer needed

Reviewed Changes

Copilot reviewed 28 out of 30 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
js/package.json Updated ESLint and plugin dependencies to v9-compatible versions
js/eslint.config.mjs New flat config format with equivalent rule configuration
js/.eslintrc.js Removed legacy configuration file
js/web/test/unittests/opset.ts Replaced expect assertion with explicit error throw
js/web/test/test-runner.ts Replaced expect assertion with explicit error throw
js/web/test/test-types.ts Removed no-namespace disable comment
js/node/test/unittests/lib/tensor.ts Refactored ternary expressions to if/else blocks
js/react_native/e2e/src/App.tsx Updated deprecated ban-types to no-empty-object-type
Multiple files Removed unnecessary eslint-disable comments and unused catch variables

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@fs-eire fs-eire merged commit c6c6d78 into main Oct 28, 2025
92 checks passed
@fs-eire fs-eire deleted the fs-eire/upgrade-eslint branch October 28, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants