Skip to content

Conversation

@jstarks
Copy link
Member

@jstarks jstarks commented Oct 28, 2025

No description provided.

@jstarks jstarks requested review from a team as code owners October 28, 2025 04:14
Copilot AI review requested due to automatic review settings October 28, 2025 04:14
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR disables trace-level logging in release builds of the OpenHCL underhill_entry component by setting the maximum log level to debug. This is intended to improve performance in production by eliminating trace-level overhead.

Key Changes

  • Adds explicit tracing dependency with release_max_level_debug feature to cap log levels in release builds
  • Configures xtask to ignore the unused-deps check for the tracing dependency since it's present only for feature configuration

@smalis-msft
Copy link
Contributor

Net difference: -591 KiB.

@jstarks
Copy link
Member Author

jstarks commented Oct 28, 2025

We should discuss this. The size difference is nice, but I'm actually more interested in just getting this tracing code out of the hot paths.

@smalis-msft
Copy link
Contributor

I'm in favor (and would be in favor of going up to debug too). I don't think we've yet had an issue where we needed to repro something with extra tracing but couldn't deploy a private build (even if it has to be tip signed). That's really the only functionality we'd be losing right?

@jstarks
Copy link
Member Author

jstarks commented Oct 28, 2025

OK. Let's see how much more we get with debug level. I'd prefer to keep debug unless the delta is huge, since we already do a pretty good job keeping debug out of hot paths.

@jstarks
Copy link
Member Author

jstarks commented Oct 28, 2025

Net difference: -1009 KiB.

Tempting.

@github-actions
Copy link

@jstarks jstarks closed this Oct 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants