chore: have support ReadOnlyList in function return parameters#1713
Merged
chore: have support ReadOnlyList in function return parameters#1713
Conversation
mxschmitt
commented
Mar 13, 2025
| case 'any': return `[object]${optionalSuffix}`; | ||
| case 'unknown': return `[object]${optionalSuffix}`; | ||
| case 'Array': return `[IEnumerable]${optionalSuffix}`; | ||
| case 'Array': return direction === 'out' ? `[IReadOnlyList]${optionalSuffix}` : `[IEnumerable]${optionalSuffix}`; |
Contributor
Author
There was a problem hiding this comment.
Member
There was a problem hiding this comment.
Can we share this logic between the generator and docs?
mxschmitt
commented
Mar 13, 2025
| switch (fullName(member)) { | ||
| case 'BrowserContext.addCookies.cookies': return '`Cookie`'; | ||
| case 'BrowserContext.cookies': return '`Cookie`'; | ||
| case 'BrowserContext.cookies': return '`BrowserContextCookiesResult`'; |
Contributor
Author
There was a problem hiding this comment.
Contributor
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-forest-0a29f6210-1713.centralus.azurestaticapps.net |
yury-s
reviewed
Mar 13, 2025
yury-s
reviewed
Mar 13, 2025
Member
yury-s
left a comment
yury-s
left a comment
There was a problem hiding this comment.
There is a bunch of unrelated changes, if they are due to a roll, let's land the roll separately and have generator change isolated.
| case 'any': return `[object]${optionalSuffix}`; | ||
| case 'unknown': return `[object]${optionalSuffix}`; | ||
| case 'Array': return `[IEnumerable]${optionalSuffix}`; | ||
| case 'Array': return direction === 'out' ? `[IReadOnlyList]${optionalSuffix}` : `[IEnumerable]${optionalSuffix}`; |
Member
There was a problem hiding this comment.
Can we share this logic between the generator and docs?
Contributor
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-forest-0a29f6210-1713.centralus.azurestaticapps.net |
yury-s
approved these changes
Mar 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes microsoft/playwright#35029