chore: support progressive image loading with local assets#1820
Closed
agg23 wants to merge 5 commits intomicrosoft:mainfrom
Closed
chore: support progressive image loading with local assets#1820agg23 wants to merge 5 commits intomicrosoft:mainfrom
agg23 wants to merge 5 commits intomicrosoft:mainfrom
Conversation
Skn0tt
reviewed
Aug 1, 2025
Contributor
|
Would be great if you could make this PR against the upstream and not against your fork, then we'd have preview environments and could see the impact - thanks! |
Member
|
Oh, didn't know that the branch source makes a difference! good point. |
Contributor
Author
|
Closed in favor of #1823. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A unfortunately large diff.
Integrate
plugin-ideal-image. We found the implementation automatically detects slow connections and requires a click to load the image. This requires a customProgressiveImagecomponent in order to disable the slow connection functionality.Images will now display an inline, very low res placeholder of the correct size. Images will be progressively loaded. They are also preprocessed with lossy compression to decrease total wire size and physical pixel size.