Conversation
jwunderl
approved these changes
Nov 11, 2022
Collaborator
Author
|
I will wait for Eric. I don't think query string works after this though. |
Member
|
Would it be confusing that you can't go to |
Member
|
Ah yes, this was something we were discussing as future work to allow it to propagate query string (e.g. could even be something like converting |
Collaborator
Author
|
Yes that is what I was thinking. However, # gets propagated. Probably need backend change. I will pass on to Eric. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.