Skip to content

Update detached/empty payload error message in COSE decoder#371

Merged
ivarprudnikov merged 9 commits intomainfrom
copilot/sub-pr-370
Feb 27, 2026
Merged

Update detached/empty payload error message in COSE decoder#371
ivarprudnikov merged 9 commits intomainfrom
copilot/sub-pr-370

Conversation

Copy link
Contributor

Copilot AI commented Feb 26, 2026

  • Update error message to "Detached or empty payloads are not supported" in app/src/cose.h
  • Update matching test assertions in app/unit-tests/cose_test.cpp
  • Remove accidentally committed _codeql_detected_source_root symlink and add to .gitignore
  • Fix clang-format issues and verify all CI checks pass (C++ format, Python types/mypy, Python imports/isort, Python format/black, copyright notices, release notes)

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 2 commits February 26, 2026 13:53
Co-authored-by: ivarprudnikov <1052642+ivarprudnikov@users.noreply.github.com>
Co-authored-by: ivarprudnikov <1052642+ivarprudnikov@users.noreply.github.com>
Copilot AI changed the title [WIP] Update error message for empty or nil payload in cose Update detached/empty payload error message in COSE decoder Feb 26, 2026
Base automatically changed from feat/improve-cose-errors to main February 26, 2026 16:25
@ivarprudnikov
Copy link
Member

@copilot remove file _codeql_detected_source_root‎ from git changes

@ivarprudnikov ivarprudnikov marked this pull request as ready for review February 26, 2026 16:30
@ivarprudnikov ivarprudnikov requested a review from a team as a code owner February 26, 2026 16:30
Co-authored-by: ivarprudnikov <1052642+ivarprudnikov@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Feb 26, 2026

@copilot remove file _codeql_detected_source_root‎ from git changes

Done in commit 45ba42b. Removed the _codeql_detected_source_root symlink from git tracking and added it to .gitignore to prevent it from being committed again.

@ivarprudnikov
Copy link
Member

@copilot run ./scripts/ci-checks.sh to check for Python type safety issues and attempt to fix them if you can.

Co-authored-by: ivarprudnikov <1052642+ivarprudnikov@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Feb 27, 2026

@copilot run ./scripts/ci-checks.sh to check for Python type safety issues and attempt to fix them if you can.

Ran ./scripts/ci-checks.sh — all checks pass in ab95ca3. No Python type safety issues were found (mypy reported "Success: no issues found in 49 source files"). The only issue was a C++ clang-format violation in cose_test.cpp which has been fixed.

@ivarprudnikov ivarprudnikov merged commit 92c1733 into main Feb 27, 2026
9 checks passed
@ivarprudnikov ivarprudnikov deleted the copilot/sub-pr-370 branch February 27, 2026 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants