Skip to content

Conversation

@heyitsaamir
Copy link
Collaborator

@heyitsaamir heyitsaamir commented Sep 8, 2025

Not done yet. Botframework uses aiohttp, and teams-ai uses FastAPI (which is ASGI based). We need to figure out how to make them work together.

PR Dependency Tree

This tree was auto-generated by Charcoal

@lilyydu
Copy link
Collaborator

lilyydu commented Sep 20, 2025

did some exploration this afternoon, and one solution (not quite the cleanest) is adding it in as a middleware. It can get pretty messy though so I'm not a huge fan, and if there's any future changes w/ BF, it may be hard to integrate

although I think we have two other things we'll need to watch for:

  1. the botbuilder packages support lower versions of python - with v1, this led to a lot of dependency blockers (GH would report security vulnerabilities)
  2. we might also run into customers that use other frameworks like django, so maybe the solution is to add more flexibility in general with our web server approach? maybe define integration packages depending on which framework is being used. this makes more sense to me, but it'll require a larger amount of changes to our existing implementation. in C#, we kept the web server as a separate package, so maybe we can explore that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants