-
Couldn't load subscription status.
- Fork 4
Change AttachmentLayout enum from "carousel" to "grid" #186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: heyitsaamir <48929123+heyitsaamir@users.noreply.github.com>
Co-authored-by: heyitsaamir <48929123+heyitsaamir@users.noreply.github.com>
|
@copilot these are not helpful tests. Remove them. |
Co-authored-by: heyitsaamir <48929123+heyitsaamir@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the AttachmentLayout enum to align with the TypeScript implementation in teams.ts PR #381, changing the enum value from "carousel" to "grid".
Key changes:
- Updated
AttachmentLayout.CAROUSELtoAttachmentLayout.GRIDwith value "grid" - Updated docstring in the
with_attachment_layoutmethod to reflect the new enum value
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/api/src/microsoft/teams/api/models/attachment/attachment_layout.py | Changed enum member from CAROUSEL = "carousel" to GRID = "grid" |
| packages/api/src/microsoft/teams/api/activities/message/message.py | Updated docstring to reference "grid" instead of "carousel" |
Aligns with teams.ts PR #381 to update the
AttachmentLayoutenum values.Changes
AttachmentLayout.CAROUSEL→AttachmentLayout.GRID(value:"carousel"→"grid")Usage
Note: This is a breaking change for code using
AttachmentLayout.CAROUSEL.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.