Add drag-and-drop tab merging into split panes#19966
Draft
d-init-d wants to merge 1 commit intomicrosoft:mainfrom
Draft
Add drag-and-drop tab merging into split panes#19966d-init-d wants to merge 1 commit intomicrosoft:mainfrom
d-init-d wants to merge 1 commit intomicrosoft:mainfrom
Conversation
This adds preview and directional drop targets so dragged tabs can merge into another tab without losing session state.
Contributor
|
@d-init-d please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
Member
|
Can you please install the SDK and actually build this locally? It seems weird to have us review code that you're not even sure compiles cleanly, let alone works the way you expect. When you do have it running, can you share a screen recording of it in action? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
up,right,down,left, and automatic center drops.Implementation Checklist
ContentIdstate instead of starting fresh sessions.Verification
git diff --checkd-init-d:feature/tab-drag-split-pane10.0.22621.0.NET Framework 4.7.2Developer Pack / targeting packMicrosoft.NET.SdkNotes