Open
Conversation
DHowett
reviewed
Mar 17, 2026
Comment on lines
+378
to
+380
| const auto& theme = _settingsSource.GlobalSettings().CurrentTheme(); | ||
| const bool hasThemeForSettings{ theme.Settings() != nullptr }; | ||
| const auto& requestedTheme = hasThemeForSettings ? theme.Settings().RequestedTheme() : theme.RequestedTheme(); |
Member
There was a problem hiding this comment.
Suggested change
| const auto& theme = _settingsSource.GlobalSettings().CurrentTheme(); | |
| const bool hasThemeForSettings{ theme.Settings() != nullptr }; | |
| const auto& requestedTheme = hasThemeForSettings ? theme.Settings().RequestedTheme() : theme.RequestedTheme(); | |
| const auto theme = _settingsSource.GlobalSettings().CurrentTheme(); | |
| const auto hasThemeForSettings{ theme.Settings() != nullptr }; | |
| const auto requestedTheme = hasThemeForSettings ? theme.Settings().RequestedTheme() : theme.RequestedTheme(); |
DHowett
reviewed
Mar 17, 2026
|
|
||
| // GH#19927 - Theme the search box's internal popup now that the | ||
| // visual tree is ready and control templates are applied | ||
| const auto& theme = _settingsSource.GlobalSettings().CurrentTheme(); |
Member
There was a problem hiding this comment.
(is it guaranteed that there is a theme?)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Popups are in their own separate tree, so we had to find it and set the theme ourselves.
Validation Steps Performed
Prereq: Windows theme = light + terminal theme = dark
✅ settings search dropdown is dark theme
Closes #19927